Re: [PATCH] io_uring: Add IO_U_F_DEVICE_ERROR to identify error types

[Jens Axboe <axboe@kernel.dk>]

On Thu, 26 Sep 2024 09:41:34 +0900, Minwoo Im wrote:
> __io_u_log_error expects a positive value of io_u->error parsing it with
> strerror() expecting it to be an errno.  io_uring_cmd (cmd_type=nvme),
> for example, has returned errno value as a positive value and
> device-specific CQE status type and code as well.
> 
> Commit 78831c6b35c5 ("io_uring: Fix the flip to negative of CQE status")
> has put the abs() to the cqe->res, and it caused confusions between the
> actual CQE stauts and the system error value (errno).  Now we have
> Commit 2a13699a89dc ("io_uring: Add .errdetails to parse CQ status"),
> meaning that io_uring_cmd ioengines will parse the actual value of
> io_u->error value as CQE status value, so we should know if the value is
> for CQE status or errno.
> 
> [...]

Applied, thanks!

[1/1] io_uring: Add IO_U_F_DEVICE_ERROR to identify error types
      commit: ebe67b667f25694ead4caa0198598318f891b345

Best regards,
-- 
Jens Axboe