From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH 0/9] testing patches References: <20191210175442.2975-1-vincentfu@gmail.com> From: Vincent Fu Message-ID: <191fa593-aecc-a077-c24f-980f6d8280e0@gmail.com> Date: Wed, 11 Dec 2019 14:53:24 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: Sitsofe Wheeler Cc: Jens Axboe , fio , Vincent Fu List-ID: On 12/10/19 4:32 PM, Sitsofe Wheeler wrote: > On Tue, 10 Dec 2019 at 17:56, wrote: >> >> From: Vincent Fu >> >> Jens, please consider this series of patches related to testing. >> >> The patches improve t/run-fio-tests.py in various ways, most prominently >> adding support for Windows and macOS. >> >> Also included are travis and appveyor patches that add run-fio-tests.py >> as a step. Currently both the travis and appveyor build processes >> complete in less than four minutes. Adding run-fio-tests.py increases >> this to about 20 minutes for travis and 14 minutes for appveyor. > > In general I think this work is fantastic and much needed (you can > search through the fio commit logs using "git log --grep 'size='" to > find jobs files that have caused issues in the past and may be worth > turning into tests at some point). However, I think making the builds > so slow may be a disadvantage rather than a benefit. I agree with > nearly all the patch set bar running this by default with > travis/appveyor... > Many thanks for the feedback, Sitsofe. I agree that the build times are uncomfortably long, but since I had done the work I thought I would offer the patches to Jens. Jens, what do you think? Would you like me to re-send the patch series without the appveyor and travis changes?