From: Jens Axboe <jens.axboe@oracle.com>
To: Carl Henrik Lunde <chlunde@ping.uio.no>
Cc: fio@vger.kernel.org
Subject: Re: Bug in stats, KB/s vs. KiB/s?
Date: Mon, 20 Apr 2009 08:52:20 +0200 [thread overview]
Message-ID: <20090420065220.GS4593@kernel.dk> (raw)
In-Reply-To: <ed038eb20904190607l1f3dde9bi9e595f3b6bdefec6@mail.gmail.com>
On Sun, Apr 19 2009, Carl Henrik Lunde wrote:
> Hi! I think there's a bug in the stats report:
>
> When I specify rate=8192 I got 8388 KiB/s in the report, which happens
> to be 8192*1.024.
>
> I believe the problem is that bytes / ms is used as KiB/s. I'm not
> sure what the correct value of "base" should be (1000 vs. 1024), but
> it doesn't affect the result. I haven't reviewed all the reporting,
> but at least I *think* these three are wrong.
Hmm, it actually seems like the reporting is correct, but that the rate
throttling is off by 1024/1000. So the fix is likely there somewhere,
I'll take a look.
--
Jens Axboe
next prev parent reply other threads:[~2009-04-20 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 13:07 Bug in stats, KB/s vs. KiB/s? Carl Henrik Lunde
2009-04-20 6:52 ` Jens Axboe [this message]
2009-04-20 6:59 ` Jens Axboe
2009-04-20 8:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090420065220.GS4593@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=chlunde@ping.uio.no \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox