From: Jens Axboe <jens.axboe@oracle.com>
To: "Alan D. Brunelle" <Alan.Brunelle@hp.com>
Cc: fio@vger.kernel.org
Subject: Re: Bug in fio: infinite loop when using two volumes crafted from one MD?
Date: Fri, 11 Sep 2009 21:34:12 +0200 [thread overview]
Message-ID: <20090911193411.GO14984@kernel.dk> (raw)
In-Reply-To: <1252695820.5814.31.camel@cail>
On Fri, Sep 11 2009, Alan D. Brunelle wrote:
> Well, the attached patch appears to fix the problem: When looking to add
> an underlying device we first check to see if its in the list of current
> devices. If so, we skip this add.
>
> As I know next to nothing about the innards of fio, I'd be a little
> leery of taking this in, but at least it allows me to proceed! :-)
OK, so it's probably corrupting the list on a double insert. Your check
is likely fine, even if there are alternative ways we could fix this.
I'll add it for now, thanks for debugging this Alan!
--
Jens Axboe
next prev parent reply other threads:[~2009-09-11 19:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 15:59 Bug in fio: infinite loop when using two volumes crafted from one MD? Alan D. Brunelle
2009-09-11 16:35 ` Jens Axboe
2009-09-11 19:03 ` Alan D. Brunelle
2009-09-11 19:34 ` Jens Axboe [this message]
2009-09-11 20:16 ` Alan D. Brunelle
2009-09-11 20:23 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2009-10-23 3:12 Glen Ogilvie
2009-10-23 4:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090911193411.GO14984@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=Alan.Brunelle@hp.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox