From: Jens Axboe <jens.axboe@oracle.com>
To: Glen Ogilvie <gogilvie@oss.co.nz>
Cc: fio@vger.kernel.org,
Michael O'Sullivan <michael.osullivan@auckland.ac.nz>
Subject: Re: fio-1.34.1, what we are doing with it and some patches we use.
Date: Tue, 3 Nov 2009 21:52:17 +0100 [thread overview]
Message-ID: <20091103205216.GP8742@kernel.dk> (raw)
In-Reply-To: <20091031070123.GW10727@kernel.dk>
On Sat, Oct 31 2009, Jens Axboe wrote:
> On Fri, Oct 30 2009, Glen Ogilvie wrote:
> > Dear Jens Axboe and the FIO mailing list.
> >
> > I have been working with Mike O'Sullivan, a senior lecturer at the
> > University of Auckland, New Zealand. He has been adapting fio 1.34.1
> > to work with iolog files and also to be able to read a "wait" command
> > to allow the iolog file to specify a wait (in millisecs) before the
> > next io. Mike's not completely confident that his changes are correct
> > in the overall fio picture, but they are working with the iolog files
> > we are using. What we did:
> >
> > 1) We incorporated wait into iolog file reading; 2) We made some
> > modifications so that read_iolog worked.
> >
> > We have attached a patch for fio-1.34.1.tar.bz2 along with some
> > demonstration fio config files and iolog files.
> >
> > We are doing this so we can use an open source SPC-1 emulator to
> > generate SPC-1 like workloads and then run them in fio.
> >
> > Hope some of this work is useful. Feed back is welcome, we are not
> > experts in FIO and SPC-1, so this may have problems.
>
> Interesting! I think the patch you attached is reversed, you want to
> diff old tree -> new tree. Otherwise the patch looks nice and simple,
> one of the hunks look like a generic bug fix for leaking memory and
> probably should be applied first as it isn't really part of this
> "feature".
>
> Another thing to keep in mind is the format of the iolog file. Did you
> check whether the old versions just ignore the 'wait' line? If yes, we
> can keep the format. Otherwise we probably need to bump it.
I fixed up the style and committed it, thanks a lot for contributing
this!
--
Jens Axboe
next prev parent reply other threads:[~2009-11-03 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <321292794.59661256869305878.JavaMail.root@zimbra.oss.co.nz>
2009-10-30 2:25 ` fio-1.34.1, what we are doing with it and some patches we use Glen Ogilvie
2009-10-31 7:01 ` Jens Axboe
2009-11-03 20:52 ` Jens Axboe [this message]
2010-02-09 22:30 ` Integrating open SPC-1 benchmark into fio Michael O'Sullivan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091103205216.GP8742@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=fio@vger.kernel.org \
--cc=gogilvie@oss.co.nz \
--cc=michael.osullivan@auckland.ac.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox