From: Jens Axboe <jens.axboe@oracle.com>
To: "H. Tolley" <h_tolley@hotmail.com>
Cc: fio@vger.kernel.org
Subject: Re: FIO bug
Date: Sat, 6 Feb 2010 23:36:19 +0100 [thread overview]
Message-ID: <20100206223619.GQ1025@kernel.dk> (raw)
In-Reply-To: <SNT103-W60447568C188F46ABEC5CEFF540@phx.gbl>
On Fri, Feb 05 2010, H. Tolley wrote:
>
> The function static void get_file_system_type(struct fio_file *f)��
> (in file filesetup.c) has a call to lstat(..) which if given a
> symbolic link will give information about the link instead of
> information about the target of the link.� In Solaris it is very
> common that the disk device nodes in /dev/dsk/ are symbolic links to
> files in /devices/... and so the call to lstat(..) will not properly
> identify a file as a block device instead of a normal file.�
>
> A call to stat(..) on a filename that represents a block device will
> not return the proper size on Solaris.� Combined with the
> above-mentioned mis-identification of a link to a block device as a
> normal file, the function file_size(..) is invoked rather than a call
> to bdev_size(..) and fio will not run properly.
>
> Fix: Can the call to lstat(..) in get_file_system_type(..) be replaced
> by a call to stat(..)?
>
> This happens on Open Solaris v10 x86_64.
That does look like a bug, that stat should return info about the real
device and not a potential link. I have committed a fix for that now.
--
Jens Axboe
next prev parent reply other threads:[~2010-02-06 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 23:30 FIO bug H. Tolley
2010-02-06 22:36 ` Jens Axboe [this message]
[not found] <CAP8ELLWHUR5_Zia8X03eOotDUW8M-5u3pA_ie=sXD8cvwh1e5g@mail.gmail.com>
2016-06-27 21:20 ` Fwd: fio bug Frank Londono
2016-06-28 5:26 ` Sitsofe Wheeler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100206223619.GQ1025@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=fio@vger.kernel.org \
--cc=h_tolley@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox