Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: fio@vger.kernel.org
Subject: [PATCH] Do not delete cgroups upon completion of fio job
Date: Wed, 31 Mar 2010 13:19:31 -0400	[thread overview]
Message-ID: <20100331171931.GH14011@redhat.com> (raw)

Currently upon fio job completion, we delete the cgroups. But in the
process we also loose important debugging information presetn in cgroup
files. For example time information in blkio.time, sector information in
blkio.sectors and how many a times a group was dequeued blkio.dequeue.
Leaving the cgroups as it is, allows one to go and inspect those files
after the fio job is complete.

Secondly, cgroups might have already been created by user before fio job
started. In that case it is not very right to delete cgroups after job
completion.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
 cgroup.c |    1 -
 1 file changed, 1 deletion(-)

Index: fio/cgroup.c
===================================================================
--- fio.orig/cgroup.c	2010-03-31 13:29:49.000000000 -0400
+++ fio/cgroup.c	2010-03-31 13:31:55.788002620 -0400
@@ -65,7 +65,6 @@ void cgroup_kill(struct flist_head *clis
 
 	flist_for_each_safe(n, tmp, clist) {
 		cm = flist_entry(n, struct cgroup_member, list);
-		rmdir(cm->root);
 		flist_del(&cm->list);
 		sfree(cm->root);
 		sfree(cm);



             reply	other threads:[~2010-03-31 17:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-31 17:19 Vivek Goyal [this message]
2010-03-31 17:26 ` [PATCH] Do not delete cgroups upon completion of fio job Jens Axboe
2010-03-31 17:35   ` Vivek Goyal
2010-03-31 17:38     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100331171931.GH14011@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox