Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Martin Steigerwald <ms@teamix.de>
To: fio@vger.kernel.org, 700580@bugs.debian.org
Subject: [PATCH] Make test for gnuplot work with empty strings.
Date: Mon, 11 Mar 2013 16:22:56 +0100	[thread overview]
Message-ID: <201303111622.57044.ms@teamix.de> (raw)

When I launch fio_generate_plots on a system where gnuplot is not installed I
get this error :

$ fio_generate_plots test
Making bw logs
/usr/bin/fio_generate_plots: 42: /usr/bin/fio_generate_plots: -: not found

That's because the test checking whether gnuplot is installed is failing
because of an empty variable :
GNUPLOT=$(which gnuplot)
if [ ! -x $GNUPLOT ]; then
        echo You need gnuplot installed to generate graphs
        exit 1
fi

Indeed the command "test -x" is exiting with code 0.

To correct this we should enclose the variable with quotes :
if [ ! -x "$GNUPLOT" ]; then

Then the script is going into the test properly :
$ fio_generate_plots test
You need gnuplot installed to generate graphs

I copied problem description by Hervé from the Debian bug report below.

Fixes:
Bug#700580: /usr/bin/fio_generate_plots: -: not found
http://bugs.debian.org/700580

Reported-By: Hervé Werner <hwerner@score-md.com>
Tested-By: Hervé Werner <hwerner@score-md.com>
Tested-By: Martin Steigerwald <ms@teamix.de>
---
 fio_generate_plots |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fio_generate_plots b/fio_generate_plots
index 4285415..5e2febd 100755
--- a/fio_generate_plots
+++ b/fio_generate_plots
@@ -8,7 +8,7 @@ if [ "$1"x = "x" ]; then
 fi
 
 GNUPLOT=$(which gnuplot)
-if [ ! -x $GNUPLOT ]; then
+if [ ! -x "$GNUPLOT" ]; then
 	echo You need gnuplot installed to generate graphs
 	exit 1
 fi
-- 
1.7.10.4


             reply	other threads:[~2013-03-11 15:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-11 15:22 Martin Steigerwald [this message]
2013-03-12 12:16 ` [PATCH] Make test for gnuplot work with empty strings Jens Axboe
2013-08-05 14:40   ` Martin Steigerwald
2013-08-05 14:48     ` Erwan Velu
2013-08-05 15:07       ` Martin Steigerwald
2013-08-05 15:12         ` Erwan Velu
2013-08-05 15:28         ` Jens Axboe
2013-08-05 15:32           ` Martin Steigerwald
2013-08-05 14:58     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201303111622.57044.ms@teamix.de \
    --to=ms@teamix.de \
    --cc=700580@bugs.debian.org \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox