From: Jens Axboe <axboe@kernel.dk>
To: Gavin Martin <gavin_martin@xyratex.com>
Cc: fio@vger.kernel.org
Subject: Re: Unable to Configure latest build
Date: Fri, 12 Apr 2013 14:17:00 +0200 [thread overview]
Message-ID: <20130412121700.GR12244@kernel.dk> (raw)
In-Reply-To: <20130412113453.GQ12244@kernel.dk>
On Fri, Apr 12 2013, Jens Axboe wrote:
> On Fri, Apr 12 2013, Gavin Martin wrote:
> > On 12 April 2013 12:13, Jens Axboe <axboe@kernel.dk> wrote:
> > > On Fri, Apr 12 2013, Jens Axboe wrote:
> > >> But sounds like it would be a good idea to turn zlib into a soft
> > >> requirement.
> > >
> > > The below does that, I have committed it. Please test.
> > >
> > >
> > > diff --git a/client.c b/client.c
> > > index eb695ff..13e84f6 100644
> > > --- a/client.c
> > > +++ b/client.c
> >
> > Hi Jens,
> >
> > Tested the above (with ./configure) and it does work now without the
> > zlib-devel package installed. Don't you need that if the
> > --enable-gfio argument is used? Just as a quick test I ran
> > ./configure --enable-gfio, and it didn't fail because of not finding
> > zlib?
> >
> > Sorry to be a pain, I'm not sure if it was just my install or if
> > others would have the same problem?
>
> gfio should still work fine. It's only use for the io log transfers for
> gfio, and that will now go out without compression if both ends don't
> have zlib support.
There was a missing one-liner in gclient.c. There's no zlib usage in
there, it's all in the generic client/server code in server.c and
client.c. It compiles and works fine with that one-liner.
http://git.kernel.dk/?p=fio.git;a=commit;h=aa79e6aa308868fef1437fd6783cdd354a6e9bdb
--
Jens Axboe
next prev parent reply other threads:[~2013-04-12 12:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 7:40 Unable to Configure latest build Gavin Martin
2013-04-12 8:13 ` Jens Axboe
2013-04-12 8:27 ` Gavin Martin
2013-04-12 8:42 ` Jens Axboe
2013-04-12 9:31 ` Gavin Martin
2013-04-12 9:46 ` Jens Axboe
2013-04-12 11:13 ` Jens Axboe
2013-04-12 11:31 ` Gavin Martin
2013-04-12 11:34 ` Jens Axboe
2013-04-12 12:17 ` Jens Axboe [this message]
2013-04-12 10:55 ` Greg Freemyer
2013-04-12 11:16 ` Gavin Martin
2013-04-14 10:01 ` Greg Freemyer
2013-04-14 11:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130412121700.GR12244@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=gavin_martin@xyratex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox