From: Jens Axboe <axboe@kernel.dk>
To: Aaron Carroll <xaaronc@gmail.com>
Cc: "Krishnamurthy, Anush" <anush.krishnamurthy@intel.com>,
"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: Make FIO for Android
Date: Sun, 14 Apr 2013 10:13:22 +0200 [thread overview]
Message-ID: <20130414081322.GB12244@kernel.dk> (raw)
In-Reply-To: <CAKCZDg=U5rqhBd98cD6QeKOSLkfoeZPva4VdnjdbSMyuO4UyqA@mail.gmail.com>
On Sun, Apr 14 2013, Aaron Carroll wrote:
> On 14 April 2013 04:05, Jens Axboe <axboe@kernel.dk> wrote:
> > On Sat, Apr 13 2013, Aaron Carroll wrote:
> >> On 12 April 2013 18:04, Jens Axboe <axboe@kernel.dk> wrote:
> >> > On Fri, Apr 12 2013, Aaron Carroll wrote:
> >> >> s pointer from integer without a
> >> >> > cast [enabled by default]
> >> >> > cgroup.c:46:2: warning: implicit declaration of function 'endmntent'
> >> >> > [-Wimplicit-function-declaration]
> >> >> > cgroup.c: At top level:
> >> >> > cgroup.c:78:6: error: redefinition of 'cgroup_kill'
> >> >> > cgroup.h:24:20: note: previous definition of 'cgroup_kill' was here
> >> >> > cgroup.c:147:5: error: redefinition of 'cgroup_setup'
> >> >> > cgroup.h:13:19: note: previous definition of 'cgroup_setup' was here
> >> >> > cgroup.c:189:6: error: redefinition of 'cgroup_shutdown'
> >> >> > cgroup.h:20:20: note: previous definition of 'cgroup_shutdown' was here
> >> >> > make: *** [cgroup.o] Error 1
> >> >>
> >> >> What compiler generates that? As I said I'm now getting clean builds
> >> >> for Android.
> >> >
> >> > I grabbed the 32-bit NDK from the page you referenced.
> >>
> >> I'm using that exact NDK and don't get that error. Weird.
> >
> > What about the mntent related ones? Looking at mntent.h in
> > sysroot/usr/include/, it contains:
> > [..]
> > So bits missing... The cgroup stuff I didn't look at. You are using the
> > 32-bit variant as well, not the 64-bit one?
>
> Hi Jens,
>
> Yes, 32-bit NDK generated with arch=x86 platform=android-14.
> Something seems weird with your build... cgroup.c should not be
> compiled at all for Android.
>
> $ git pull
> $ make clean
> $ make CROSS_COMPILE=~/dev/android-toolchains-r8e/x86-4.6/bin/i686-linux-android-
That works for me. Perhaps a small paragraph in the README under the
Building section mentioning how to build for android would be a good
idea?
--
Jens Axboe
prev parent reply other threads:[~2013-04-14 8:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 17:57 Make FIO for Android Krishnamurthy, Anush
[not found] ` <CAKCZDgnM85AcwD6Ss5YWNjXwY-OE7QFQh22nFdEFHkta_N0hRA@mail.gmail.com>
2013-04-12 1:20 ` Krishnamurthy, Anush
2013-04-12 2:48 ` Aaron Carroll
2013-04-12 3:17 ` Krishnamurthy, Anush
2013-04-12 3:28 ` Aaron Carroll
2013-04-12 3:37 ` Aaron Carroll
2013-04-12 5:58 ` Jens Axboe
2013-04-12 6:10 ` Aaron Carroll
2013-04-12 6:18 ` Jens Axboe
2013-04-12 6:24 ` Aaron Carroll
2013-04-12 6:30 ` Jens Axboe
2013-04-12 6:34 ` Aaron Carroll
2013-04-12 6:38 ` Jens Axboe
2013-04-12 6:51 ` Aaron Carroll
2013-04-12 7:00 ` Jens Axboe
2013-04-12 7:10 ` Aaron Carroll
2013-04-12 7:12 ` Aaron Carroll
2013-04-12 7:16 ` Jens Axboe
2013-04-12 7:22 ` Aaron Carroll
2013-04-12 8:04 ` Jens Axboe
2013-04-13 3:47 ` Aaron Carroll
2013-04-13 18:05 ` Jens Axboe
2013-04-14 5:28 ` Aaron Carroll
2013-04-14 8:13 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130414081322.GB12244@kernel.dk \
--to=axboe@kernel.dk \
--cc=anush.krishnamurthy@intel.com \
--cc=fio@vger.kernel.org \
--cc=xaaronc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox