From: Jens Axboe <axboe@kernel.dk>
To: peter chang <dpf@google.com>
Cc: gwendal@google.com, fio@vger.kernel.org
Subject: Re: [PATCH] fix memory allocation in the cases we may need to align
Date: Wed, 24 Apr 2013 16:31:39 -0600 [thread overview]
Message-ID: <20130424223139.GT2354@kernel.dk> (raw)
In-Reply-To: <1366840545-11768-1-git-send-email-dpf@google.com>
On Wed, Apr 24 2013, peter chang wrote:
> when using the sg backend we crash w/ a SEGV in fio_sgio_getevents()
> because of memory corruption from the IO. when we allocate the td's
> backing store there's a possible post-allocation adjustment to page
> align the buffers. however, the extra memory that this alignment may
> need is not taken into account when allocating the buffer.
>
> Tested:
> - the problematic fio file looks like
> fdha347:~# cat foo.fio
> [global]
> bs=64k
> thread
> rw=read
> size=100g
> time_based=1
> runtime=60
> iodepth=1
>
> [sdc]
> ioengine=sg
> filename=/dev/sg2
> numjobs=1
Thanks, good description and the potential extra alignment bytes isn't
an issue. Applied!
--
Jens Axboe
prev parent reply other threads:[~2013-04-24 22:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 21:55 [PATCH] fix memory allocation in the cases we may need to align peter chang
2013-04-24 22:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424223139.GT2354@kernel.dk \
--to=axboe@kernel.dk \
--cc=dpf@google.com \
--cc=fio@vger.kernel.org \
--cc=gwendal@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox