Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: chris meyers <chris.meyers.fsu@gmail.com>
Cc: fio@vger.kernel.org
Subject: Re: Latency log, add filename to record
Date: Sat, 16 Nov 2013 11:19:44 -0700	[thread overview]
Message-ID: <20131116181944.GD8179@kernel.dk> (raw)
In-Reply-To: <CAHPXfP7PFPwAK=CbPYkL_XU5UfjCjvOyf0atdD0fL6e3BF6c3g@mail.gmail.com>

On Thu, Nov 07 2013, chris meyers wrote:
> https://github.com/axboe/fio/pull/3
> The above patch modifies the CSV latency log (write_lat_log options)
> by appending the filename to which the record is related. Said
> differently, the filename to which the I/O was issued to. When I first
> set out to add this feature I had indended to create a new log file in
> order to distrubt the latency log file format as little as possible.
> This, however, was not easily doable given the structure of the fio
> code. Now, in order to still provide this feature while maintaining
> the legacy latency file format I propose two options.
> (1) A configuration options as an extention to write_lat_log. For example:
> write_lat_log=mylogfile:with_filename
> (2) As a seperate configuration option that modifies the write_lat_log
> format. For example:
> write_lat_log_with_filename=bool
> 
> This email is to start a discussion and solicit feedback on the
> proposed feature as well as the cooresponding configuration trigger.

Chris, sorry for being late on this! I'll get to this on Monday and give
you some constructive criticism.

-- 
Jens Axboe


  reply	other threads:[~2013-11-16 18:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 20:42 Latency log, add filename to record chris meyers
2013-11-16 18:19 ` Jens Axboe [this message]
2013-11-22  3:36   ` Jens Axboe
2013-11-22  3:44     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131116181944.GD8179@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=chris.meyers.fsu@gmail.com \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox