From: Jens Axboe <axboe@kernel.dk>
To: Grant Grundler <grundler@chromium.org>
Cc: Wallence Lu <wallencelu@gmail.com>, FIO_list <fio@vger.kernel.org>
Subject: Re: A bug in combining fsrange and verify
Date: Tue, 28 Jan 2014 10:26:09 -0700 [thread overview]
Message-ID: <20140128172609.GL20264@kernel.dk> (raw)
In-Reply-To: <CANEJEGsfPUTzV4iwkYCDY1xwagW8uW+nimBzLOLDt2uzZHPGYg@mail.gmail.com>
On Mon, Jan 27 2014, Grant Grundler wrote:
> On Mon, Jan 27, 2014 at 3:31 PM, Jens Axboe <axboe@kernel.dk> wrote:
> ...
> >> > Works for me with the 2.1.4 release. It's actually broken in current
> >> > -git, due to the numberio patches..
> >>
> >> You mean all of the "verify_only" support patches or specifically this patch:
> >>
> >> commit da0a7bd224bb9331f27bb4b20394dd5c8fa3acb0
> >> Author: Juan Casse <jcasse@chromium.org>
> >> Date: Tue Sep 17 14:06:12 2013 -0700
> >>
> >> Adds check for numberio during verify phase.
> >>
> >> I can take a look at this tomorrow... let me see if I have the job
> >> file in another email.
> >
> > It looks like it's actually catching the issue, when I take a closer
> > look.
>
> OH. Got it. :) Good. Had me worried for a moment.
But another bug has been uncovered. If you run this:
[global]
filename=fio.ver
loops=10
verify=crc32
[random-rw]
size=31457280
rw=randrw
fio will complain about unmatched seeds in later iterations...
> BTW, it looks like there is also a bug in "random_pattern_fill"
> support. When specifying verify_pattern the problem went away. See
> this bug:
> https://code.google.com/p/chromium/issues/detail?id=337651
>
> my workaround is here:
> https://chromium-review.googlesource.com/#/c/183813/
>
> (should probably start a new thread for that)
Please do :-)
>
> > I'm afraid there might be overlapping ranges for bsrange=.
>
> I can reproduce with fio-2.1.2 + verify_only patches (output below).
> It's always a 512 byte long corruption which in fact would suggest
> "off-by-one" overlapping ranges.
Note that the print is actually wrong. It's verifying in extents of 512,
but does verify the whole thing. But yes, there's a bug there, but the
length print is not correct.
--
Jens Axboe
next prev parent reply other threads:[~2014-01-28 17:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 2:07 A bug in combining fsrange and verify Wallence Lu
2014-01-27 19:22 ` Jens Axboe
2014-01-27 20:42 ` Wallence Lu
2014-01-27 22:46 ` Jens Axboe
2014-01-27 23:03 ` Jens Axboe
2014-01-27 23:16 ` Grant Grundler
2014-01-27 23:31 ` Jens Axboe
2014-01-28 0:00 ` Grant Grundler
2014-01-28 17:26 ` Jens Axboe [this message]
2014-02-03 22:05 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140128172609.GL20264@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=grundler@chromium.org \
--cc=wallencelu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox