From: Jens Axboe <axboe@kernel.dk>
To: Grant Grundler <grundler@chromium.org>
Cc: FIO_list <fio@vger.kernel.org>,
Puthikorn Voravootivat <puthik@chromium.org>
Subject: Re: Rip out verify_backlog support?
Date: Wed, 5 Feb 2014 12:32:14 -0700 [thread overview]
Message-ID: <20140205193214.GI27534@kernel.dk> (raw)
In-Reply-To: <CANEJEGuqYiSQnyw2bVNFa3CKqmZK6+-3y5dDT4h3iccU-n0cAA@mail.gmail.com>
On Wed, Feb 05 2014, Grant Grundler wrote:
> Today, fio has two distinct phases of operation: workload and then verify.
>
> But there is this hack which is in-between those two: verify_backlog
> which makes things a lot more complicated. This hack was added to
> limit the amount of memory needed to track the IOs that needed to be
> verify. I'm going to argue "verify_each_loop" could do the same thing
> and keep fio internals simpler (strictly two phases). If the goal is
> to have longer running, well defined workloads that can be verified,
> then verifying after each iteration makes more sense. In other words,
> the jobs should define a workload limit (amount of IO or time) and
> then iterate that constraint as many times as they want to reach the
> duration they want.
>
> Thoughts?
We've actually caught actual bugs with the verify_backlog in the past,
where you want verify closer to when the write has happened. So I'd
prefer if we fix those up instead.
For memory reduction, I think the experimental_verify is the way to go.
Basically have roll back support for any of the generated offsets etc,
so we don't need to track it at all.
--
Jens Axboe
next prev parent reply other threads:[~2014-02-05 19:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 18:43 Rip out verify_backlog support? Grant Grundler
2014-02-05 19:32 ` Jens Axboe [this message]
2014-02-05 19:44 ` Grant Grundler
2014-02-05 19:53 ` Jens Axboe
2014-02-05 21:03 ` Grant Grundler
2014-02-05 21:28 ` Jens Axboe
2014-02-05 21:47 ` Grant Grundler
2014-02-05 22:30 ` Jens Axboe
2014-02-06 3:34 ` Jens Axboe
2014-02-06 18:58 ` Puthikorn Voravootivat
2014-02-06 19:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205193214.GI27534@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=grundler@chromium.org \
--cc=puthik@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox