From: Sitsofe Wheeler <sitsofe@yahoo.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: [PATCH] io_u_qiter: Fix buffer overrun
Date: Thu, 13 Feb 2014 20:05:03 +0000 [thread overview]
Message-ID: <20140213200459.GA31261@sucs.org> (raw)
In-Reply-To: <20140213161733.GD10926@kernel.dk>
On Thu, Feb 13, 2014 at 09:17:33AM -0700, Jens Axboe wrote:
>
> Initially I didn't see the issue, but then I realized that ->io_us is a
> pointer to the io_u pointer. So it is an issue. The fix isn't super
> pretty, but it gets rid of the bug, so I'll apply it. It might be nicer
> to split it into a top and bottom define.
Can you explain this top and bottom define more - would this let me turn
it into a while loop?
The only reason for the current abuse was because I couldn't think of a
another way to fix it while preserving the macro...
--
Sitsofe | http://sucs.org/~sits/
next prev parent reply other threads:[~2014-02-13 20:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 7:06 [PATCH] io_u_qiter: Fix buffer overrun Sitsofe Wheeler
2014-02-13 16:17 ` Jens Axboe
2014-02-13 20:05 ` Sitsofe Wheeler [this message]
2014-02-13 20:34 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213200459.GA31261@sucs.org \
--to=sitsofe@yahoo.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox