From: Jens Axboe <axboe@kernel.dk>
To: kusumi.tomohiro@gmail.com
Cc: fio@vger.kernel.org, Tomohiro Kusumi <tkusumi@tuxera.com>
Subject: Re: [PATCH 1/5] Rename FIO_TYPE_BD to FIO_TYPE_BLOCK
Date: Thu, 19 Jan 2017 16:10:12 -0700 [thread overview]
Message-ID: <20170119231012.GA27799@kernel.dk> (raw)
In-Reply-To: <1484761107-21387-1-git-send-email-tkusumi@tuxera.com>
On Thu, Jan 19 2017, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
>
> Since character device is FIO_TYPE_CHAR, BLOCK (or BLK) makes
> better sense for block device.
>
> This may break external ioengines on compile-time, but ioengines
> usually don't refer to file type which are regfile/blk/chr/pipe
> (which I believe makes sense to commit this change as there's
> been changes that break not only api but also abi).
Thanks, applied 1-5.
--
Jens Axboe
prev parent reply other threads:[~2017-01-19 23:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 17:38 [PATCH 1/5] Rename FIO_TYPE_BD to FIO_TYPE_BLOCK kusumi.tomohiro
2017-01-18 17:38 ` [PATCH 2/5] Fix typo for "job" in plural kusumi.tomohiro
2017-01-18 17:38 ` [PATCH 3/5] Refactor fio_show_ioengine_help() kusumi.tomohiro
2017-01-18 17:38 ` [PATCH 4/5] Move options_mem_dupe() to parse.c kusumi.tomohiro
2017-01-18 17:38 ` [PATCH 5/5] Change td_var() to take void* for the first arg kusumi.tomohiro
2017-01-19 23:10 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119231012.GA27799@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=kusumi.tomohiro@gmail.com \
--cc=tkusumi@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox