From: Jens Axboe <axboe@kernel.dk>
To: kusumi.tomohiro@gmail.com
Cc: fio@vger.kernel.org, Tomohiro Kusumi <tkusumi@tuxera.com>
Subject: Re: [PATCH 01/11] configure: Disable CONFIG_POSIX_FALLOCATE on NetBSD even if posix_fallocate(3) compiles
Date: Mon, 1 May 2017 14:44:23 -0600 [thread overview]
Message-ID: <20170501204421.GA13925@kernel.dk> (raw)
In-Reply-To: <20170501184820.31025-1-tkusumi@tuxera.com>
On Mon, May 01 2017, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
>
> fio on NetBSD may have CONFIG_POSIX_FALLOCATE configuration enabled
> since posix_fallocate(3) compiles (at least on recent versions),
> but this is actually not supported on UFS as mentioned in below wiki
> and fio result.
>
> https://wiki.netbsd.org/projects/project/ffs-fallocate/
> > This functionality is not currently implemented for FFS;
>
> compile_prog() during ./configure fails to catch this as it doesn't
> run the test code after compilation (and it needs to use a valid fd
> in order to do runtime test).
>
> This commit simply disables CONFIG_POSIX_FALLOCATE on NetBSD regardless
> of compilation result on ./configure. It doesn't check the fs type,
> but it should be enough provided that UFS is the fs used by majority
> of users and there's also no real alternative for disk fs.
I'd much rather we just avoid it if we get EOPNOTSUPP at runtime. That
way we don't have to change anything later on, when/if NetBSD does get
support for fallocate.
--
Jens Axboe
next prev parent reply other threads:[~2017-05-01 20:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 18:48 [PATCH 01/11] configure: Disable CONFIG_POSIX_FALLOCATE on NetBSD even if posix_fallocate(3) compiles kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 02/11] configure: Add compile_exec_prog() to compile and execute the binary kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 03/11] configure: Use single square brackets (POSIX) kusumi.tomohiro
2017-05-02 5:36 ` Sitsofe Wheeler
2017-05-02 5:58 ` Tomohiro Kusumi
2017-05-01 18:48 ` [PATCH 04/11] configure: Use compile_exec_prog() for s390_z196_facilities kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 05/11] configure: output_sym CONFIG_GFIO kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 06/11] configure: Add missing <string.h> to avoid bogus warning kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 07/11] configure: Add void* cast " kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 08/11] configure: Check gfio test result via return value (not printf) kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 09/11] configure: Add missing ########## kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 10/11] configure: Add missing $val != "yes" test to override compile_prog() result kusumi.tomohiro
2017-05-01 18:48 ` [PATCH 11/11] configure: Add print_config() for "<config>... <yes|no>" outputs kusumi.tomohiro
2017-05-01 20:44 ` Jens Axboe [this message]
2017-05-01 20:54 ` [PATCH 01/11] configure: Disable CONFIG_POSIX_FALLOCATE on NetBSD even if posix_fallocate(3) compiles Tomohiro Kusumi
2017-05-01 20:57 ` Jens Axboe
2017-05-01 21:10 ` Tomohiro Kusumi
2017-05-01 20:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501204421.GA13925@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=kusumi.tomohiro@gmail.com \
--cc=tkusumi@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).