From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.nue.novell.com ([195.135.221.5]:49852 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754881AbdFWTph (ORCPT ); Fri, 23 Jun 2017 15:45:37 -0400 Date: Fri, 23 Jun 2017 21:45:08 +0200 From: Andreas Herrmann Subject: Re: [PATCH v3 0/4] stat: Modify info for bw and add iops stats Message-ID: <20170623194508.GA3090@suselix.suse.de> References: <20170623174300.7937-1-aherrmann@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: fio-owner@vger.kernel.org List-Id: fio@vger.kernel.org To: Jens Axboe Cc: fio@vger.kernel.org On Fri, Jun 23, 2017 at 12:15:34PM -0600, Jens Axboe wrote: > On 06/23/2017 11:42 AM, Andreas Herrmann wrote: > > Hi, > > > > this is a resubmission of patches 1 and 2 to add iops statistics and > > number of samples for iops and bw stats to normal and json output > > formats. Patches are rebased on fio-2.21-26-gcf6b7fb4. > > > > I'd like to see similar information added to terse format. Thus I've > > added patches 3 and 4. First to merge terse functions (reducing code > > size) and then to add a new terse format 5 where iops stats and number > > of samples for bw and iops are displayed. > > Looks good, I like it. Patch #4 needs an explanation of version 5 > of the terse format, though. Care to add that? You mean for the commit message or for the man-page or both? For the latter I think the differences between the different terse versions should be described. (Maybe I missed it but I think that is not in the man-page). Andreas