Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Stephen Bates <sbates@raithlin.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>,
	"logang@deltatee.com" <logang@deltatee.com>,
	"elliott@hpe.com" <elliott@hpe.com>
Subject: Re: [PATCH v3] rdma: Add bind option
Date: Wed, 22 Nov 2017 11:10:34 -0700	[thread overview]
Message-ID: <20171122181032.GA20487@kernel.dk> (raw)
In-Reply-To: <CF527084-479C-4085-8C3F-2F6D5F607825@raithlin.com>

On Wed, Nov 22 2017, Stephen  Bates wrote:
> >In certain configurations it can be useful to bind a rdma_cm to a
> >particular network interface. For example in multi-path or loopback.
> >
> >Add a bindname option that the local rdma_cm will try and bind too.
> >
> >The bind code is based off that used in rping [1].
> >
> >[1] https://github.com/linux-rdma/rdma-core/blob/ \
> >    master/librdmacm/examples/rping.c
> >
> >Signed-off-by: Stephen Bates <sbates@raithlin.com>
> >Reviewed-by: Logan Gunthorpe <logang@deltatee.com>>
> 
> Hi Jens
> 
> Do you have any concerns or issues with this patch?

No looks fine to me, seemed to have missed the original.

-- 
Jens Axboe



  reply	other threads:[~2017-11-22 18:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08 22:47 [PATCH v3] rdma: Add bind option sbates
2017-11-22 18:01 ` Stephen  Bates
2017-11-22 18:10   ` Jens Axboe [this message]
2017-11-22 18:24     ` Stephen  Bates
2017-11-22 20:13   ` Sitsofe Wheeler
2017-11-22 20:15     ` Jens Axboe
2017-11-22 20:22       ` Stephen  Bates
2017-11-22 20:25         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171122181032.GA20487@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=elliott@hpe.com \
    --cc=fio@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=sbates@raithlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox