From: vincentfu@gmail.com
To: axboe@kernel.dk, fio@vger.kernel.org
Cc: Vincent Fu <vincent.fu@wdc.com>
Subject: [PATCH] rate-submit: call ioengine post_init when starting workers
Date: Thu, 24 Jan 2019 14:26:42 -0500 [thread overview]
Message-ID: <20190124192642.18727-1-vincentfu@gmail.com> (raw)
From: Vincent Fu <vincent.fu@wdc.com>
ioengines with post_init steps were not fully fully initialized by
offload worker threads because the post_init function was never called.
Without this patch all libaio operations submitted in offload mode fail
because the ioengine was not fully initialized.
Fixes: 2041bd343da1 ("engines/libaio: add preliminary support for pre-mapped IO buffers")
---
rate-submit.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/rate-submit.c b/rate-submit.c
index b07a2072..cf00d9bc 100644
--- a/rate-submit.c
+++ b/rate-submit.c
@@ -165,6 +165,9 @@ static int io_workqueue_init_worker_fn(struct submit_worker *sw)
if (td_io_init(td))
goto err_io_init;
+ if (td->io_ops->post_init && td->io_ops->post_init(td))
+ goto err_io_init;
+
set_epoch_time(td, td->o.log_unix_epoch);
fio_getrusage(&td->ru_start);
clear_io_state(td, 1);
--
2.17.1
next reply other threads:[~2019-01-24 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 19:26 vincentfu [this message]
2019-01-24 20:57 ` [PATCH] rate-submit: call ioengine post_init when starting workers Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124192642.18727-1-vincentfu@gmail.com \
--to=vincentfu@gmail.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=vincent.fu@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox