From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: fio@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Damien Le Moal <damien.lemoal@wdc.com>
Subject: [PATCH v3 6/7] Restore type checking in calc_thread_status()
Date: Wed, 14 Aug 2019 13:10:11 -0700 [thread overview]
Message-ID: <20190814201012.253060-7-bvanassche@acm.org> (raw)
In-Reply-To: <20190814201012.253060-1-bvanassche@acm.org>
Due to a previous patch it is no longer necessary to hide the type of
accesses to the 'rate' and 'iops' members in struct jobs_eta.
This patch reverts commit df0ca15ce2ff ("eta: Fix compiler warning").
Cc: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
eta.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/eta.c b/eta.c
index 5900bc0fd919..286b45ee3837 100644
--- a/eta.c
+++ b/eta.c
@@ -392,9 +392,6 @@ bool calc_thread_status(struct jobs_eta *je, int force)
static unsigned long long disp_io_iops[DDIR_RWDIR_CNT];
static struct timespec rate_prev_time, disp_prev_time;
- void *je_rate = (void *) je->rate;
- void *je_iops = (void *) je->iops;
-
if (!force) {
if (!(output_format & FIO_OUTPUT_NORMAL) &&
f_out == stdout)
@@ -510,7 +507,7 @@ bool calc_thread_status(struct jobs_eta *je, int force)
if (write_bw_log && rate_time > bw_avg_time && !in_ramp_time(td)) {
calc_rate(unified_rw_rep, rate_time, io_bytes, rate_io_bytes,
- je_rate);
+ je->rate);
memcpy(&rate_prev_time, &now, sizeof(now));
add_agg_sample(sample_val(je->rate[DDIR_READ]), DDIR_READ, 0);
add_agg_sample(sample_val(je->rate[DDIR_WRITE]), DDIR_WRITE, 0);
@@ -522,8 +519,8 @@ bool calc_thread_status(struct jobs_eta *je, int force)
if (!force && !eta_time_within_slack(disp_time))
return false;
- calc_rate(unified_rw_rep, disp_time, io_bytes, disp_io_bytes, je_rate);
- calc_iops(unified_rw_rep, disp_time, io_iops, disp_io_iops, je_iops);
+ calc_rate(unified_rw_rep, disp_time, io_bytes, disp_io_bytes, je->rate);
+ calc_iops(unified_rw_rep, disp_time, io_iops, disp_io_iops, je->iops);
memcpy(&disp_prev_time, &now, sizeof(now));
--
2.22.0.rc1
next prev parent reply other threads:[~2019-08-14 20:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 20:10 [PATCH v3 0/7] Seven fio patches Bart Van Assche
2019-08-14 20:10 ` [PATCH v3 1/7] zbd: Declare local functions 'static' Bart Van Assche
2019-08-14 20:10 ` [PATCH v3 2/7] zbd: Improve robustness of unit tests Bart Van Assche
2019-08-14 20:10 ` [PATCH v3 3/7] Optimize the code that copies strings Bart Van Assche
2019-08-14 20:10 ` [PATCH v3 4/7] Refine packed annotations in stat.h Bart Van Assche
2019-08-14 20:10 ` [PATCH v3 5/7] Verify the absence of holes in struct jobs_eta at compile time Bart Van Assche
2019-08-14 20:10 ` Bart Van Assche [this message]
2019-08-14 20:10 ` [PATCH v3 7/7] Makefile: Add 'fulltest' target Bart Van Assche
2019-08-14 21:11 ` Sitsofe Wheeler
2019-08-14 21:14 ` Bart Van Assche
2019-08-14 21:40 ` Sitsofe Wheeler
2019-08-14 21:02 ` [PATCH v3 0/7] Seven fio patches Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814201012.253060-7-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox