From: vincentfu@gmail.com
To: axboe@kernel.dk, fio@vger.kernel.org
Cc: Vincent Fu <vincent.fu@wdc.com>
Subject: [PATCH 2/2] smalloc: use SMALLOC_BPI instead of SMALLOC_BPB in add_pool()
Date: Tue, 3 Sep 2019 13:44:45 -0400 [thread overview]
Message-ID: <20190903174445.1212-3-vincentfu@gmail.com> (raw)
In-Reply-To: <20190903174445.1212-1-vincentfu@gmail.com>
From: Vincent Fu <vincent.fu@wdc.com>
Change the calculation of free_blocks in add_pool() to use SMALLOC_BPI
instead of SMALLOC_BPB. These two constants are coincidentally the same
on Linux and Windows but SMALLOC_BPI is the correct one to use.
free_blocks is the number of available blocks of size SMALLOC_BPB. It is
the product of the number of unsigned integers in the bitmap
(bitmap_blocks) and the number of bits per unsigned integer
(SMALLOC_BPI).
---
smalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/smalloc.c b/smalloc.c
index 39bf47a5..fa00f0ee 100644
--- a/smalloc.c
+++ b/smalloc.c
@@ -173,7 +173,7 @@ static bool add_pool(struct pool *pool, unsigned int alloc_size)
pool->mmap_size = alloc_size;
pool->nr_blocks = bitmap_blocks;
- pool->free_blocks = bitmap_blocks * SMALLOC_BPB;
+ pool->free_blocks = bitmap_blocks * SMALLOC_BPI;
mmap_flags = OS_MAP_ANON;
#ifdef CONFIG_ESX
--
2.17.1
next prev parent reply other threads:[~2019-09-03 17:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 17:44 [PATCH 0/2] smalloc fixes vincentfu
2019-09-03 17:44 ` [PATCH 1/2] smalloc: allocate struct pool array from shared memory vincentfu
2019-09-03 17:44 ` vincentfu [this message]
2019-09-03 18:32 ` [PATCH 0/2] smalloc fixes Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903174445.1212-3-vincentfu@gmail.com \
--to=vincentfu@gmail.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=vincent.fu@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox