From: Alexey Dobriyan <adobriyan@gmail.com>
To: Keith Busch <Keith.Busch@wdc.com>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: [PATCH] fio: add NVMe engine
Date: Fri, 27 Mar 2020 22:06:12 +0300 [thread overview]
Message-ID: <20200327190612.GA7570@avx2> (raw)
In-Reply-To: <BY5PR04MB66894E274A6785CADDD23200FFCC0@BY5PR04MB6689.namprd04.prod.outlook.com>
On Fri, Mar 27, 2020 at 02:26:41PM +0000, Keith Busch wrote:
> On 3/27/20 8:25 AM, Keith Busch wrote:
> > If you're really going to do it, though, I would recommend not using
> > NVME_IOCTL_SUBMIT_IO, and instead always use the more flexible
> > NVME_IOCTL_SUBMIT_IO.
>
>
> Err, that second ioctl should have said "NVME_IOCTL_IO_CMD".
Why? NVME_IOCTL_SUBMIT_IO is so much simpler.
Except trim, when there is no choice.
next prev parent reply other threads:[~2020-03-27 19:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 20:44 [PATCH] fio: add NVMe engine Alexey Dobriyan
2020-03-26 22:05 ` Jens Axboe
2020-03-27 6:19 ` Alexey Dobriyan
2020-03-27 14:45 ` Jens Axboe
2020-03-27 0:56 ` Damien Le Moal
2020-03-27 6:14 ` Alexey Dobriyan
2020-03-27 14:25 ` Keith Busch
2020-03-27 14:26 ` Keith Busch
2020-03-27 19:06 ` Alexey Dobriyan [this message]
2020-03-27 21:05 ` Keith Busch
2020-03-27 14:47 ` Jens Axboe
2020-03-27 19:01 ` Alexey Dobriyan
2020-03-27 21:25 ` Jens Axboe
2020-03-27 21:58 ` Keith Busch
2020-03-28 13:41 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327190612.GA7570@avx2 \
--to=adobriyan@gmail.com \
--cc=Damien.LeMoal@wdc.com \
--cc=Keith.Busch@wdc.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox