From: Alexey Dobriyan <adobriyan@gmail.com>
To: shinichiro.kawasaki@wdc.com
Cc: damien.lemoaal@wdc.com, axboe@kernel.dk, fio@vger.kernel.org
Subject: Re: [PATCH 3/3] zbd: Ensure first I/O is write for random read/write to sequential zones
Date: Tue, 14 Apr 2020 00:21:11 +0300 [thread overview]
Message-ID: <20200413212111.GA19503@avx2> (raw)
> zbd_adjust_block
> + if (td_rw(td) && !f->zbd_info->sectors_with_data
> + && !td->o.read_beyond_wp)
> + io_u->ddir = DDIR_WRITE;
Oh, you've noticed this too. :-)
This will issue the first write with wrong length if bs[DDIR_READ] != bs[DDIR_WRITE].
Adjusting in zbd_adjust_block() is too late.
next reply other threads:[~2020-04-13 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 21:21 Alexey Dobriyan [this message]
2020-04-14 3:35 ` [PATCH 3/3] zbd: Ensure first I/O is write for random read/write to sequential zones Shinichiro Kawasaki
-- strict thread matches above, loose matches on Subject: below --
2020-04-13 8:32 [PATCH 0/3] zbd: Fix issues found with test script Shin'ichiro Kawasaki
2020-04-13 8:33 ` [PATCH 3/3] zbd: Ensure first I/O is write for random read/write to sequential zones Shin'ichiro Kawasaki
2020-04-13 9:09 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413212111.GA19503@avx2 \
--to=adobriyan@gmail.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoaal@wdc.com \
--cc=fio@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox