From: Alexey Dobriyan <adobriyan@gmail.com>
To: dmitry.fomichev@wdc.com
Cc: fio@vger.kernel.org
Subject: Re: [PATCH] zbd: remove reset_zone flag from fio_zone_info
Date: Wed, 19 Aug 2020 15:56:09 +0300 [thread overview]
Message-ID: <20200819125609.GA278226@localhost.localdomain> (raw)
> The reset_zone flag that is defined in fio_zone_info structure is
> only referenced in zbd_adjust_block() function. Convert this flag
> to a local variable and save some room in zbd_info array which can
> be pretty large when running fio against high capacity zoned devices.
This flag should be kept.
Test can crash or be interrupted leaving hw in indeterminate state,
it must be restarted from clean state. Or test can be precondition and
zone should not be reset.
Can't distinguish these two cases from write pointers alone.
Given that precondition and real workload can be in different fio
instances, this information must be somehow given to fio process
and either force or not force zone reset (config option obviously)
> @@ -41,7 +40,6 @@ struct fio_zone_info {
> enum zbd_zone_type type:2;
> enum zbd_zone_cond cond:4;
> unsigned int open:1;
> - unsigned int reset_zone:1;
Does it save space? Bitfields stick together after all.
next reply other threads:[~2020-08-19 12:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 12:56 Alexey Dobriyan [this message]
2020-08-19 19:35 ` [PATCH] zbd: remove reset_zone flag from fio_zone_info Dmitry Fomichev
2020-08-21 17:07 ` Alexey Dobriyan
2020-08-27 19:18 ` Dmitry Fomichev
2020-09-02 12:49 ` Alexey Dobriyan
-- strict thread matches above, loose matches on Subject: below --
2020-08-18 0:02 Dmitry Fomichev
2020-08-19 4:59 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819125609.GA278226@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=dmitry.fomichev@wdc.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox