From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Ankit Kumar <ankit.kumar@samsung.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"fio@vger.kernel.org" <fio@vger.kernel.org>,
"krish.reddy@samsung.com" <krish.reddy@samsung.com>,
"prakash.v@samsung.com" <prakash.v@samsung.com>
Subject: Re: [PATCH 1/2] Add missing documentation for job_max_open_zones.
Date: Wed, 4 Aug 2021 05:52:35 +0000 [thread overview]
Message-ID: <20210804055234.2ybmcqastjeseghy@shindev> (raw)
In-Reply-To: <1627986516-4814-2-git-send-email-ankit.kumar@samsung.com>
Hello Ankit,
On Aug 03, 2021 / 15:58, Ankit Kumar wrote:
> ---
> HOWTO | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/HOWTO b/HOWTO
> index 59c7f1f..d4e620d 100644
> --- a/HOWTO
> +++ b/HOWTO
> @@ -1055,6 +1055,11 @@ Target file/device
> number of open zones is defined as the number of zones to which write
> commands are issued.
>
> +.. option:: job_max_open_zones=int
> +
> + Limit on the number of simultaneously opened zones per single
> + thread/process.
> +
This change looks good to me, but I think the commit message title can be
improved. "HOWTO: " prefix will help to identify the change target file. Also,
I suggest to remove the period in the title. As far as I know, all fio commits
do not have period in their commit message titles.
> .. option:: zone_reset_threshold=float
>
> A number between zero and one that indicates the ratio of logical
> --
> 1.8.3.1
>
--
Best Regards,
Shin'ichiro Kawasaki
next prev parent reply other threads:[~2021-08-04 5:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210803111208epcas5p2fec4fec945de52fb57986f2ef5e2bcfe@epcas5p2.samsung.com>
2021-08-03 10:28 ` [PATCH 0/2] ZBD fix with random zone index logic and missing documentation Ankit Kumar
2021-08-03 10:28 ` [PATCH 1/2] Add missing documentation for job_max_open_zones Ankit Kumar
2021-08-04 5:52 ` Shinichiro Kawasaki [this message]
2021-08-03 10:28 ` [PATCH 2/2] zbd: Improve random zone index generation logic Ankit Kumar
2021-08-04 5:59 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804055234.2ybmcqastjeseghy@shindev \
--to=shinichiro.kawasaki@wdc.com \
--cc=ankit.kumar@samsung.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=krish.reddy@samsung.com \
--cc=prakash.v@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox