From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Shinichiro Kawasaki Subject: Re: [PATCH 2/2] zbd: Improve random zone index generation logic Date: Wed, 4 Aug 2021 12:04:15 +0000 Message-ID: <20210804120415.nhaecaxouupintm5@shindev> References: <20210804112308.28062-1-ankit.kumar@samsung.com> <20210804112308.28062-3-ankit.kumar@samsung.com> In-Reply-To: <20210804112308.28062-3-ankit.kumar@samsung.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 To: Ankit Kumar Cc: "axboe@kernel.dk" , "fio@vger.kernel.org" , "krish.reddy@samsung.com" , "prakash.v@samsung.com" List-ID: On Aug 04, 2021 / 16:53, Ankit Kumar wrote: > Existing random zone index generation logic is dependent on the file size= . > For smaller I/O sizes the random zone index always return a particular > section of open zones. As this index is used to return one of the open zo= nes, > it was observed that after one of the max_open_zones / job_max_open_zones= limit > is reached all further I/O's are redirected to only a few open zones till= they > are full. >=20 > This patch modifies the random zone index genration logic so that it is u= niform > across all the open zones. >=20 > It reverts part of the commit 6463db6c1 > ('fio: fix interaction between offset/size limited threads and > "max_open_zones"') >=20 > Signed-off-by: Ankit Kumar Looks good to me. Also, I confirmed that this patch improves the randomness= of open zone selection, and it preserves the intent of the commit 6463db6c1. Tested-by: Shin'ichiro Kawasaki Reviewed-by: Shin'ichiro Kawasaki --=20 Best Regards, Shin'ichiro Kawasaki=