From: Kanchan Joshi <joshi.k@samsung.com>
To: Ankit Kumar <ankit.kumar@samsung.com>
Cc: axboe@kernel.dk, fio@vger.kernel.org, krish.reddy@samsung.com,
anuj20.g@samsung.com
Subject: Re: [PATCH v2 3/8] nvme: add nvme opcodes, structures and helper functions
Date: Fri, 27 May 2022 12:59:47 +0530 [thread overview]
Message-ID: <20220527072947.GA16232@test-zns> (raw)
In-Reply-To: <20220526144809.14877-4-ankit.kumar@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On Thu, May 26, 2022 at 08:18:04PM +0530, Ankit Kumar wrote:
>+void fio_nvme_uring_cmd_prep(struct nvme_uring_cmd *cmd, struct io_u *io_u,
>+ struct iovec *iov)
>+{
>+ struct nvme_data *data = FILE_ENG_DATA(io_u->file);
>+ __u64 slba;
>+ __u32 nlb;
>+
>+ slba = io_u->offset / data->lba_size;
>+ nlb = (io_u->xfer_buflen / data->lba_size) - 1;
>+
>+ memset(cmd, 0, sizeof(struct nvme_uring_cmd));
Is this better or setting remaining fields (which are not populated
down) to zero.
>+ /* cdw10 and cdw11 represent starting lba */
>+ cmd->cdw10 = slba & 0xffffffff;
>+ cmd->cdw11 = slba >> 32;
>+ /* cdw12 represent number of lba's for read/write */
>+ cmd->cdw12 = nlb;
>+ if (iov) {
>+ iov->iov_base = io_u->xfer_buf;
>+ iov->iov_len = io_u->xfer_buflen;
>+ cmd->addr = (__u64)(uintptr_t)iov;
>+ cmd->data_len = 1;
Is this correct? Do we always get 1 vector to deal with.
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2022-05-27 7:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220526145343epcas5p362cd1b702fc0d11d21bca2880d6e288c@epcas5p3.samsung.com>
2022-05-26 14:48 ` [PATCH v2 0/8] Add support for uring passthrough commands Ankit Kumar
2022-05-26 14:48 ` [PATCH v2 1/8] io_uring.h: add IORING_SETUP_SQE128 and IORING_SETUP_CQE32 Ankit Kumar
2022-05-26 14:48 ` [PATCH v2 2/8] configure: check nvme uring command support Ankit Kumar
2022-05-26 14:48 ` [PATCH v2 3/8] nvme: add nvme opcodes, structures and helper functions Ankit Kumar
2022-05-27 7:29 ` Kanchan Joshi [this message]
2022-05-27 12:24 ` Jens Axboe
2022-05-27 13:21 ` Ankit Kumar
2022-05-27 14:45 ` Vincent Fu
2022-05-27 14:54 ` Jens Axboe
2022-05-27 18:07 ` Jens Axboe
2022-05-26 14:48 ` [PATCH v2 4/8] engines/io_uring: add new I/O engine for uring passthrough support Ankit Kumar
2022-05-27 6:37 ` Kanchan Joshi
2022-05-26 14:48 ` [PATCH v2 5/8] docs: document options for io_uring_cmd I/O engine Ankit Kumar
2022-05-27 6:54 ` Kanchan Joshi
2022-05-27 13:26 ` Ankit Kumar
2022-05-27 15:19 ` Vincent Fu
2022-05-26 14:48 ` [PATCH v2 6/8] zbd: Check for direct flag only if its block device Ankit Kumar
2022-05-27 16:15 ` Vincent Fu
2022-05-30 10:14 ` Shinichiro Kawasaki
2022-05-26 14:48 ` [PATCH v2 7/8] engines/io_uring: Enable zone device support for io_uring_cmd I/O engine Ankit Kumar
2022-05-27 17:23 ` Vincent Fu
2022-05-26 14:48 ` [PATCH v2 8/8] examples: add 2 example job file for io_uring_cmd engine Ankit Kumar
2022-05-27 17:30 ` Vincent Fu
2022-05-27 18:05 ` Jens Axboe
2022-05-27 7:02 ` [PATCH v2 0/8] Add support for uring passthrough commands Kanchan Joshi
2022-05-27 13:24 ` Ankit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220527072947.GA16232@test-zns \
--to=joshi.k@samsung.com \
--cc=ankit.kumar@samsung.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=krish.reddy@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox