Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Ankit Kumar <ankit.kumar@samsung.com>
To: axboe@kernel.dk
Cc: fio@vger.kernel.org, vincentfu@gmail.com,
	Ankit Kumar <ankit.kumar@samsung.com>
Subject: [PATCH 2/2] doc: update about sqthread_poll
Date: Fri,  4 Nov 2022 16:43:14 +0530	[thread overview]
Message-ID: <20221104111314.25535-3-ankit.kumar@samsung.com> (raw)
In-Reply-To: <20221104111314.25535-1-ankit.kumar@samsung.com>

Update that when sqthread_poll is enabled the submission and completion
latencies reported may not be accurate. This is because the actual submission
is done by the kernel polling thread.

Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
---
 HOWTO.rst | 4 +++-
 fio.1     | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/HOWTO.rst b/HOWTO.rst
index 0fb5593e..dea625fe 100644
--- a/HOWTO.rst
+++ b/HOWTO.rst
@@ -2299,7 +2299,9 @@ with the caveat that when used on the command line, they must come after the
 	kernel of available items in the SQ ring. If this option is set, the
 	act of submitting IO will be done by a polling thread in the kernel.
 	This frees up cycles for fio, at the cost of using more CPU in the
-	system.
+	system. The submission and completion latencies reported may not be
+	accurate as fio has no idea when the kernel polling thread submits the
+	actual I/O.
 
 .. option:: sqthread_poll_cpu : [io_uring] [io_uring_cmd]
 
diff --git a/fio.1 b/fio.1
index 4324a975..95c5ce55 100644
--- a/fio.1
+++ b/fio.1
@@ -2090,7 +2090,9 @@ sqthread_poll option.
 Normally fio will submit IO by issuing a system call to notify the kernel of
 available items in the SQ ring. If this option is set, the act of submitting IO
 will be done by a polling thread in the kernel. This frees up cycles for fio, at
-the cost of using more CPU in the system.
+the cost of using more CPU in the system. The submission and completion
+latencies reported may not be accurate as fio has no idea when the kernel
+polling thread submits the actual I/O.
 .TP
 .BI (io_uring,io_uring_cmd)sqthread_poll_cpu
 When `sqthread_poll` is set, this option provides a way to define which CPU
-- 
2.17.1


      parent reply	other threads:[~2022-11-04 12:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20221104112440epcas5p24f13b6a1c3db0b38b8453a896fb31575@epcas5p2.samsung.com>
2022-11-04 11:13 ` [PATCH 0/2] slat and clat reporting with sqthread_poll Ankit Kumar
2022-11-04 11:13   ` [PATCH 1/2] engines:io_uring: slat and clat calculation " Ankit Kumar
2022-11-22 22:25     ` Vincent Fu
2022-11-22 22:56       ` Jens Axboe
2022-11-04 11:13   ` Ankit Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221104111314.25535-3-ankit.kumar@samsung.com \
    --to=ankit.kumar@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=vincentfu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox