From: Ankit Kumar <ankit.kumar@samsung.com>
To: axboe@kernel.dk, vincentfu@gmail.com
Cc: fio@vger.kernel.org, Ankit Kumar <ankit.kumar@samsung.com>
Subject: [PATCH 03/21] init: write sequence behavior change for verify_only mode
Date: Thu, 27 Feb 2025 16:17:09 +0530 [thread overview]
Message-ID: <20250227104727.1794982-4-ankit.kumar@samsung.com> (raw)
In-Reply-To: <20250227104727.1794982-1-ankit.kumar@samsung.com>
Change the behavior for verify_only mode to not disable
verify_write_sequence unless its explicitly enabled.
Update the fio doc. accordingly.
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
---
HOWTO.rst | 3 ++-
fio.1 | 3 ++-
init.c | 6 ++++--
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/HOWTO.rst b/HOWTO.rst
index 3f2bde18..c7c131e7 100644
--- a/HOWTO.rst
+++ b/HOWTO.rst
@@ -3816,7 +3816,8 @@ Verification
invocation of this workload. This option allows one to check data multiple
times at a later date without overwriting it. This option makes sense only
for workloads that write data, and does not support workloads with the
- :option:`time_based` option set.
+ :option:`time_based` option set. :option:`verify_write_sequence` will be
+ disabled in this mode, unless its explicitly enabled.
.. option:: do_verify=bool
diff --git a/fio.1 b/fio.1
index 3c5f02b3..88d3be81 100644
--- a/fio.1
+++ b/fio.1
@@ -3542,7 +3542,8 @@ Do not perform specified workload, only verify data still matches previous
invocation of this workload. This option allows one to check data multiple
times at a later date without overwriting it. This option makes sense only
for workloads that write data, and does not support workloads with the
-\fBtime_based\fR option set.
+\fBtime_based\fR option set. \fBverify_write_sequence\fR option will be
+disabled in this mode, unless its explicitly enabled.
.TP
.BI do_verify \fR=\fPbool
Run the verify phase after a write phase. Only valid if \fBverify\fR is
diff --git a/init.c b/init.c
index 96a03d98..dc3e7ed1 100644
--- a/init.c
+++ b/init.c
@@ -854,8 +854,10 @@ static int fixup_options(struct thread_data *td)
o->verify_interval = gcd(o->min_bs[DDIR_WRITE],
o->max_bs[DDIR_WRITE]);
- if (td->o.verify_only)
- o->verify_write_sequence = 0;
+ if (o->verify_only) {
+ if (!fio_option_is_set(o, verify_write_sequence))
+ o->verify_write_sequence = 0;
+ }
}
if (td->o.oatomic) {
--
2.25.1
next prev parent reply other threads:[~2025-02-27 7:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250227053350epcas5p31b3b5b47590d70804dade59842d87b27@epcas5p3.samsung.com>
2025-02-27 10:47 ` [PATCH 00/21] verify fixes and a new test suite Ankit Kumar
2025-02-27 7:28 ` fiotestbot
2025-02-27 10:47 ` [PATCH 01/21] filesetup: remove unnecessary check Ankit Kumar
2025-02-27 10:47 ` [PATCH 02/21] verify: add missing client/server support for verify_write_sequence Ankit Kumar
2025-02-27 10:47 ` Ankit Kumar [this message]
2025-02-27 10:47 ` [PATCH 04/21] fio: add verify_header_seed option Ankit Kumar
2025-02-27 10:47 ` [PATCH 05/21] verify: disable header seed checking instead of overwriting it Ankit Kumar
2025-02-27 10:47 ` [PATCH 06/21] verify: enable header seed check for 100% write jobs Ankit Kumar
2025-02-27 10:47 ` [PATCH 07/21] verify: disable header seed check for verify_only jobs Ankit Kumar
2025-02-27 10:47 ` [PATCH 08/21] verify: header seed check for read only workloads Ankit Kumar
2025-02-27 10:47 ` [PATCH 09/21] verify: fix verify issues with norandommap Ankit Kumar
2025-02-27 10:47 ` [PATCH 10/21] verify: disable write sequence checks with norandommap and iodepth > 1 Ankit Kumar
2025-02-27 10:47 ` [PATCH 11/21] backend: fix verify issue during readwrite Ankit Kumar
2025-02-27 10:47 ` [PATCH 12/21] init: fixup verify_offset option Ankit Kumar
2025-02-27 10:47 ` [PATCH 13/21] verify: fix verify issue with offest modifiers Ankit Kumar
2025-02-27 10:47 ` [PATCH 14/21] verify: adjust fio_offset_overlap_risk to include randommap Ankit Kumar
2025-02-27 10:47 ` [PATCH 15/21] t/fiotestcommon: do not require nvmecdev argument for Requirements Ankit Kumar
2025-02-27 10:47 ` [PATCH 16/21] t/fiotestlib: improve JSON decoding Ankit Kumar
2025-02-27 10:47 ` [PATCH 17/21] t/fiotestlib: display stderr size when it is not empty but should be Ankit Kumar
2025-02-27 10:47 ` [PATCH 18/21] t/verify.py: Add verify test script Ankit Kumar
2025-02-27 10:47 ` [PATCH 19/21] t/fiotestcommon: add a success pattern for long tests Ankit Kumar
2025-02-27 10:47 ` [PATCH 20/21] t/run-fio-test: add t/verify.py Ankit Kumar
2025-02-27 10:47 ` [PATCH 21/21] ci: add nightly test for verify Ankit Kumar
2025-02-27 16:54 ` [PATCH 00/21] verify fixes and a new test suite Vincent Fu
2025-03-05 12:36 ` Shinichiro Kawasaki
2025-03-06 19:13 ` Vincent Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250227104727.1794982-4-ankit.kumar@samsung.com \
--to=ankit.kumar@samsung.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox