public inbox for fio@vger.kernel.org
 help / color / mirror / Atom feed
From: Vincent Fu <vincentfu@gmail.com>
To: fio@vger.kernel.org, axboe@kernel.dk
Cc: Vincent Fu <vincent.fu@samsung.com>
Subject: [PATCH 01/11] verify: add verify mode for a pattern with header
Date: Thu,  8 May 2025 14:58:09 -0400	[thread overview]
Message-ID: <20250508185832.3702-2-vincent.fu@samsung.com> (raw)
In-Reply-To: <20250508185832.3702-1-vincent.fu@samsung.com>

Add a verify=pattern_hdr option. Previously this was only available when
verify_pattern was set and verify= was omitted. Add a means to
explicitly select this verificaiton mode.

This is useful in the t/verify.py test script because it's troublesome
to have some jobs with a verify= option and omit this option in other
jobs when we want to test pattern verification with a header.

Signed-off-by: Vincent Fu <vincent.fu@samsung.com>
---
 HOWTO.rst | 3 +++
 fio.1     | 3 +++
 options.c | 4 ++++
 3 files changed, 10 insertions(+)

diff --git a/HOWTO.rst b/HOWTO.rst
index a5033d82..78a259ef 100644
--- a/HOWTO.rst
+++ b/HOWTO.rst
@@ -3921,6 +3921,9 @@ Verification
 			basic information and checksumming, but if this option is set, only
 			the specific pattern set with :option:`verify_pattern` is verified.
 
+		**pattern_hdr**
+			Verify a pattern in conjunction with a header.
+
 		**null**
 			Only pretend to verify. Useful for testing internals with
 			:option:`ioengine`\=null, not for much else.
diff --git a/fio.1 b/fio.1
index 8476b681..d6ee4193 100644
--- a/fio.1
+++ b/fio.1
@@ -3641,6 +3641,9 @@ Verify a strict pattern. Normally fio includes a header with some
 basic information and checksumming, but if this option is set, only
 the specific pattern set with \fBverify_pattern\fR is verified.
 .TP
+.B pattern_hdr
+Verify a pattern in conjunction with a header.
+.TP
 .B null
 Only pretend to verify. Useful for testing internals with
 `ioengine=null', not for much else.
diff --git a/options.c b/options.c
index 71c97e9e..28ffc748 100644
--- a/options.c
+++ b/options.c
@@ -3217,6 +3217,10 @@ struct fio_option fio_options[FIO_MAX_OPTS] = {
 			    .oval = VERIFY_PATTERN_NO_HDR,
 			    .help = "Verify strict pattern",
 			  },
+			  { .ival = "pattern_hdr",
+			    .oval = VERIFY_PATTERN,
+			    .help = "Verify pattern with header",
+			  },
 			  {
 			    .ival = "null",
 			    .oval = VERIFY_NULL,
-- 
2.47.2


  reply	other threads:[~2025-05-08 18:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-08 18:58 [PATCH 00/11] verify pattern interval Vincent Fu
2025-05-08 18:58 ` Vincent Fu [this message]
2025-05-08 18:58 ` [PATCH 02/11] verify: fix verify_offset when used with pattern_hdr Vincent Fu
2025-05-08 18:58 ` [PATCH 03/11] verify: make verify_pattern=%o thread safe Vincent Fu
2025-05-08 18:58 ` [PATCH 04/11] verify: omit verify type mismatch error message for pattern verify Vincent Fu
2025-05-08 18:58 ` [PATCH 05/11] t/fiotestcommon: lengthen timeout for longer tests Vincent Fu
2025-05-08 18:58 ` [PATCH 06/11] ci: for nightly verify tests use all checksum methods Vincent Fu
2025-05-08 18:58 ` [PATCH 07/11] ci: don't skip verify tests when triggered manually Vincent Fu
2025-05-08 18:58 ` [PATCH 08/11] verify: add verify_pattern_interval option Vincent Fu
2025-05-08 18:58 ` [PATCH 09/11] t/verify: test cases for running pattern and pattern_hdr Vincent Fu
2025-05-08 18:58 ` [PATCH 10/11] t/verify: Windows --output work-around Vincent Fu
2025-05-08 18:58 ` [PATCH 11/11] t/verify: add tests to exercise verify_pattern_interval Vincent Fu
2025-05-08 19:49 ` [PATCH 00/11] verify pattern interval fiotestbot
2025-05-09  0:54   ` Fio Test Bot
2025-05-16 18:08     ` Fio Test Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250508185832.3702-2-vincent.fu@samsung.com \
    --to=vincentfu@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=vincent.fu@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox