public inbox for fio@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] configure: Fix libnfs cflags and libs
@ 2025-05-09  9:50 Damien Le Moal
  2025-05-09 10:42 ` fiotestbot
  2025-05-09 13:01 ` Vincent Fu
  0 siblings, 2 replies; 3+ messages in thread
From: Damien Le Moal @ 2025-05-09  9:50 UTC (permalink / raw)
  To: fio, Vincent Fu, Jens Axboe

libnfs version 16 requires the gnutls library. Without specifying at
least -lgnutls, builds fail:

  LINK fio
/usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/15/../../../../lib64/libnfs.so: undefined reference to `gnutls_certificate_set_x509_trust_dir'
/usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/15/../../../../lib64/libnfs.so: undefined reference to `gnutls_transport_set_int2'
...

Modify the configure script to add cflags and library options for gnutls
to correctly build libnfs engine.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 715f0602..986eb0a6 100755
--- a/configure
+++ b/configure
@@ -2361,8 +2361,8 @@ print_config "DAOS File System (dfs) Engine" "$dfs"
 if test "$libnfs" != "no" ; then
   if $(pkg-config libnfs > /dev/null 2>&1); then
     libnfs="yes"
-    libnfs_cflags=$(pkg-config --cflags libnfs)
-    libnfs_libs=$(pkg-config --libs libnfs)
+    libnfs_cflags=$(pkg-config --cflags libnfs gnutls)
+    libnfs_libs=$(pkg-config --libs libnfs gnutls)
   else
     if test "$libnfs" = "yes" ; then
       feature_not_found "libnfs" "libnfs"
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] configure: Fix libnfs cflags and libs
  2025-05-09  9:50 [PATCH] configure: Fix libnfs cflags and libs Damien Le Moal
@ 2025-05-09 10:42 ` fiotestbot
  2025-05-09 13:01 ` Vincent Fu
  1 sibling, 0 replies; 3+ messages in thread
From: fiotestbot @ 2025-05-09 10:42 UTC (permalink / raw)
  To: fio

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]


The result of fio's continuous integration tests was: failure

For more details see https://github.com/fiotestbot/fio/actions/runs/14926760429

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] configure: Fix libnfs cflags and libs
  2025-05-09  9:50 [PATCH] configure: Fix libnfs cflags and libs Damien Le Moal
  2025-05-09 10:42 ` fiotestbot
@ 2025-05-09 13:01 ` Vincent Fu
  1 sibling, 0 replies; 3+ messages in thread
From: Vincent Fu @ 2025-05-09 13:01 UTC (permalink / raw)
  To: Damien Le Moal, fio, Jens Axboe

On 5/9/25 5:50 AM, Damien Le Moal wrote:
> libnfs version 16 requires the gnutls library. Without specifying at
> least -lgnutls, builds fail:
> 
>    LINK fio
> /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/15/../../../../lib64/libnfs.so: undefined reference to `gnutls_certificate_set_x509_trust_dir'
> /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/15/../../../../lib64/libnfs.so: undefined reference to `gnutls_transport_set_int2'
> ...
> 
> Modify the configure script to add cflags and library options for gnutls
> to correctly build libnfs engine.
> 
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
>   configure | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 715f0602..986eb0a6 100755
> --- a/configure
> +++ b/configure
> @@ -2361,8 +2361,8 @@ print_config "DAOS File System (dfs) Engine" "$dfs"
>   if test "$libnfs" != "no" ; then
>     if $(pkg-config libnfs > /dev/null 2>&1); then
>       libnfs="yes"
> -    libnfs_cflags=$(pkg-config --cflags libnfs)
> -    libnfs_libs=$(pkg-config --libs libnfs)
> +    libnfs_cflags=$(pkg-config --cflags libnfs gnutls)
> +    libnfs_libs=$(pkg-config --libs libnfs gnutls)
>     else
>       if test "$libnfs" = "yes" ; then
>         feature_not_found "libnfs" "libnfs"

The test builds fail because we do not install gnutls development 
libraries on the test platforms. Adding the diff below to the patch 
should resolve the failures.

Vincent

diff --git a/ci/actions-install.sh b/ci/actions-install.sh
index ad352317..30b815f3 100755
--- a/ci/actions-install.sh
+++ b/ci/actions-install.sh
@@ -32,6 +32,7 @@ DPKGCFG
          libcunit1-dev
          libcurl4-openssl-dev
          libfl-dev
+       libgnutls28-dev
          libnuma-dev
         libnfs-dev
          valgrind
@@ -106,6 +107,7 @@ install_fedora() {
          bison-devel
          git
          flex-devel
+       gnutls-devel
          gperftools
          isa-l-devel
          kernel-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-05-09 13:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-09  9:50 [PATCH] configure: Fix libnfs cflags and libs Damien Le Moal
2025-05-09 10:42 ` fiotestbot
2025-05-09 13:01 ` Vincent Fu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox