From: Damien Le Moal <dlemoal@kernel.org>
To: fio@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Vincent Fu <vincentfu@gmail.com>
Subject: [PATCH v3 6/8] engines: fileoperations: add support for DDIR_SYNCFS
Date: Fri, 27 Feb 2026 14:55:36 +0900 [thread overview]
Message-ID: <20260227055538.2334916-7-dlemoal@kernel.org> (raw)
In-Reply-To: <20260227055538.2334916-1-dlemoal@kernel.org>
Flag the filecreate, filedelete, dircreate and dirdelete IO engines with
FIO_SYNCFS to indicate that they support the syncfs operation. Change
the queue_io() function to use ddir_sync() to include all variants of
the sync operations for driving the call to do_io_u_sync(), instead of
testing for DDIR_SYNC only, which leads to ignoring other sync variants.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
engines/fileoperations.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/engines/fileoperations.c b/engines/fileoperations.c
index ce3e7c39b1a5..880eab1ebf6b 100644
--- a/engines/fileoperations.c
+++ b/engines/fileoperations.c
@@ -264,7 +264,7 @@ static int invalidate_do_nothing(struct thread_data *td, struct fio_file *f)
static enum fio_q_status queue_io(struct thread_data *td, struct io_u *io_u)
{
- if (io_u->ddir == DDIR_SYNC && do_io_u_sync(td, io_u))
+ if (ddir_sync(io_u->ddir) && do_io_u_sync(td, io_u))
io_u->error = errno;
return FIO_Q_COMPLETED;
}
@@ -329,7 +329,7 @@ static struct ioengine_ops ioengine_filecreate = {
.open_file = open_file,
.close_file = generic_close_file,
.flags = FIO_DISKLESSIO | FIO_SYNCIO | FIO_FAKEIO |
- FIO_NOSTATS | FIO_NOFILEHASH,
+ FIO_SYNCFS | FIO_NOSTATS | FIO_NOFILEHASH,
};
static struct ioengine_ops ioengine_filestat = {
@@ -357,7 +357,7 @@ static struct ioengine_ops ioengine_filedelete = {
.get_file_size = generic_get_file_size,
.open_file = delete_file,
.flags = FIO_SYNCIO | FIO_FAKEIO |
- FIO_NOSTATS | FIO_NOFILEHASH,
+ FIO_SYNCFS | FIO_NOSTATS | FIO_NOFILEHASH,
};
static struct ioengine_ops ioengine_dircreate = {
@@ -403,7 +403,7 @@ static struct ioengine_ops ioengine_dirdelete = {
.open_file = delete_file,
.unlink_file = remove_dir,
.flags = FIO_DISKLESSIO | FIO_SYNCIO | FIO_FAKEIO |
- FIO_NOSTATS | FIO_NOFILEHASH,
+ FIO_SYNCFS | FIO_NOSTATS | FIO_NOFILEHASH,
};
static void fio_init fio_fileoperations_register(void)
--
2.53.0
next prev parent reply other threads:[~2026-02-27 6:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 5:55 [PATCH v3 0/8] Introduce the end_syncfs option Damien Le Moal
2026-02-27 5:55 ` [PATCH v3 1/8] fio: introduce " Damien Le Moal
2026-02-27 5:55 ` [PATCH v3 2/8] engines: sync: add support for DDIR_SYNCFS Damien Le Moal
2026-02-27 5:55 ` [PATCH v3 3/8] engines: libaio: " Damien Le Moal
2026-02-27 5:55 ` [PATCH v3 4/8] engines: io_uring: " Damien Le Moal
2026-02-27 5:55 ` [PATCH v3 5/8] engines: fallocate: " Damien Le Moal
2026-02-27 5:55 ` Damien Le Moal [this message]
2026-02-27 5:55 ` [PATCH v3 7/8] engines: ftruncate: " Damien Le Moal
2026-02-27 5:55 ` [PATCH v3 8/8] engines: posixaio: " Damien Le Moal
2026-02-27 7:11 ` [PATCH v3 0/8] Introduce the end_syncfs option fiotestbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260227055538.2334916-7-dlemoal@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox