Re: Recent changes (master)

Jens Axboe
2019-08-15T14:28:55Z

On 8/15/19 8:27 AM, Rebecca Cran wrote:
> On 8/15/2019 6:00 AM, Jens Axboe wrote:
>> void print_status_init(int thr_number)
>> {
>> + struct jobs_eta_packed jep;
>> +
>> + compiletime_assert(sizeof(struct jobs_eta) == sizeof(jep), "jobs_eta");
>> +
>
> This broke the build on Windows:
>
>
>     CC eta.o
> In file included from fio.h:17:0,
>                  from eta.c:12:
> eta.c: In function ‘print_status_init’:
> compiler/compiler.h:38:44: error: static assertion failed: "jobs_eta"
>  #define compiletime_assert(condition, msg) _Static_assert(condition, msg)
>                                             ^
> eta.c:738:2: note: in expansion of macro ‘compiletime_assert’
>   compiletime_assert(sizeof(struct jobs_eta) == sizeof(jep), "jobs_eta");
>   ^

I did notice, I just didn't see what was wrong here. Can you remove the
assert and check the struct sizes of jobs_eta and jobs_eta_packed?

--
Jens Axboe