From: Keith Busch <kbusch@meta.com>
To: <fio@vger.kernel.org>
Cc: <axboe@kernel.dk>, <vincentfu@gmail.com>,
Keith Busch <kbusch@kernel.org>
Subject: [PATCHv2 4/4] eta: remove now unused done_secs
Date: Thu, 10 Sep 2026 09:13:10 -0700 [thread overview]
Message-ID: <20260910161310.1478081-5-kbusch@meta.com> (raw)
In-Reply-To: <20260910161310.1478081-1-kbusch@meta.com>
From: Keith Busch <kbusch@kernel.org>
Capping the ETA at the job's own remaining runtime removed the last
reader of done_secs. Drop the variable, along with the gettime call
that maintained it on every reap.
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
backend.c | 2 --
fio.h | 1 -
libfio.c | 1 -
3 files changed, 4 deletions(-)
diff --git a/backend.c b/backend.c
index 46bff828..131cda01 100644
--- a/backend.c
+++ b/backend.c
@@ -71,7 +71,6 @@ unsigned int nr_segments = 0;
unsigned int cur_segment = 0;
unsigned int stat_number = 0;
int temp_stall_ts;
-unsigned long done_secs = 0;
#ifdef PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP
pthread_mutex_t overlap_check = PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP;
#else
@@ -2505,7 +2504,6 @@ reaped:
if (td->error)
exit_value++;
- done_secs += mtime_since_now(&td->epoch) / 1000;
profile_td_exit(td);
flow_exit_job(td);
} end_for_each();
diff --git a/fio.h b/fio.h
index 494959a6..11a0d59d 100644
--- a/fio.h
+++ b/fio.h
@@ -597,7 +597,6 @@ extern bool read_only;
extern int eta_print;
extern int eta_new_line;
extern unsigned int eta_interval_msec;
-extern unsigned long done_secs;
extern int fio_gtod_offload;
extern int fio_gtod_cpu;
extern enum fio_cs fio_clock_source;
diff --git a/libfio.c b/libfio.c
index 322906c0..5fc48a1d 100644
--- a/libfio.c
+++ b/libfio.c
@@ -187,7 +187,6 @@ void reset_fio_state(void)
for (i = 0; i < nr_segments; i++)
segments[i].nr_threads = 0;
stat_number = 0;
- done_secs = 0;
}
const char *fio_get_os_string(int nr)
--
2.53.0-Meta
next prev parent reply other threads:[~2026-09-10 16:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 16:13 [PATCHv2 0/4] fio: fix eta Keith Busch
2026-09-10 16:13 ` [PATCHv2 1/4] eta: count a job that is setting up as running Keith Busch
2026-09-10 16:13 ` [PATCHv2 2/4] backend: don't mark a job as running before it has set up Keith Busch
2026-09-11 19:49 ` Vincent Fu
2026-09-10 16:13 ` [PATCHv2 3/4] eta: cap the ETA at the job's own remaining runtime Keith Busch
2026-09-10 16:13 ` Keith Busch [this message]
2026-09-11 19:45 ` [PATCHv2 0/4] fio: fix eta Vincent Fu
2026-09-11 21:09 ` fiotestbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910161310.1478081-5-kbusch@meta.com \
--to=kbusch@meta.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=kbusch@kernel.org \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox