From: Jens Axboe <axboe@kernel.dk>
To: Damien Le Moal <dlemoal@kernel.org>,
fio@vger.kernel.org, Vincent Fu <vincentfu@gmail.com>
Cc: Niklas Cassel <niklas.cassel@wdc.com>
Subject: Re: [PATCH v2 3/5] options: add priohint option
Date: Thu, 20 Jul 2023 13:33:29 -0600 [thread overview]
Message-ID: <272fe8ef-49e4-e2b9-2763-0e11fcdbb118@kernel.dk> (raw)
In-Reply-To: <20230720013114.28158-4-dlemoal@kernel.org>
On 7/19/23 7:31?PM, Damien Le Moal wrote:
> diff --git a/HOWTO.rst b/HOWTO.rst
> index 7ae8ea7b..9b9472a8 100644
> --- a/HOWTO.rst
> +++ b/HOWTO.rst
> @@ -3424,6 +3424,12 @@ Threads, processes and job synchronization
> priority setting, see I/O engine specific :option:`cmdprio_percentage`
> and :option:`cmdprio_class` options.
>
> +.. option:: priohint=int
> +
> + Set the I/O priority hint. This has effects only for devices with
> + features controlled through priority hints (e.g. block devices
> + supporting command duration limits).
> +
I would rephrase that as:
Set the I/O priority hint. This is only applicable to devices with
features controlled through priority hints (e.g. block devices
supporting command duration limits, or CDL). CDL is a way to XXX
and finish the XXX, and apply to the man page as well.
Assume people don't know what CDL is, because that will generally be
true!
--
Jens Axboe
next prev parent reply other threads:[~2023-07-20 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 1:31 [PATCH v2 0/5] Add support for I/O priority hints Damien Le Moal
2023-07-20 1:31 ` [PATCH v2 1/5] os-linux: Cleanup IO priority class and value macros Damien Le Moal
2023-07-20 9:18 ` Niklas Cassel
2023-07-20 1:31 ` [PATCH v2 2/5] os-linux: add initial support for IO priority hints Damien Le Moal
2023-07-20 1:31 ` [PATCH v2 3/5] options: add priohint option Damien Le Moal
2023-07-20 19:33 ` Jens Axboe [this message]
2023-07-20 1:31 ` [PATCH v2 4/5] cmdprio: Add support for per I/O priority hint Damien Le Moal
2023-07-20 19:36 ` Jens Axboe
2023-07-21 1:07 ` Damien Le Moal
2023-07-20 1:31 ` [PATCH v2 5/5] stats: Add hint information to per priority level stats Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=272fe8ef-49e4-e2b9-2763-0e11fcdbb118@kernel.dk \
--to=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=fio@vger.kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox