Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Martin Steigerwald <martin.steigerwald@proact.de>
To: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
Cc: FIO mailing list <fio@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>
Subject: Re: fio: uses the opposite symbol for kibibytes/kilobytes (Kb/KiB) than ISO 80000-1
Date: Thu, 26 Oct 2017 10:42:11 +0200	[thread overview]
Message-ID: <3016894.pBtxSRvArJ@merkaba> (raw)
In-Reply-To: <AT5PR84MB0082C5593313904363219920AB470@AT5PR84MB0082.NAMPRD84.PROD.OUTLOOK.COM>

Hello Robert.

Elliott, Robert (Persistent Memory) - 24.10.17, 16:23:
> > > I got this bug report for fio Debian package:
> > >
> > >
> > >
> > > fio: uses the opposite symbol for kibibytes/kilobytes (Kb/KiB) than

Sorry for safelink crap. (Need to remember to use my own SMTP to circumvent 
it.)

> https://bugs.debian.org/872321
>
> > > Its right. Completely right. The current behavior of fio is broken.
> > >
> > >
> > >
> > > But if I choose to divert from upstream default, I break *all included
> > > examples* unless I patch them up to and I risk bug reports "my script
> > > broke cause you decided to divert from upstream default behavior".
> 
> 
> No scripts were harmed in the process; the default still presumes that
> scripts are specifying numbers based on binary units.  You must add 
> kb_base=1000 to switch to correct units.

I don´t really understand this one. If I would change fio´s default behavior, I 
bet scripts may break. I wouldn´t change the meaning of "k" anyway, but just 
of "kib" and "kb", but still if a script uses one of these, it would break.

Additionally I would need to patch fio source code as I am not aware of any 
other way to change this default behavior.

I decided that I won´t do that.

So unless any change in upstream I will do with the README approach.

However, likely after an initial fio 3.1 Debian package uploaded is done. I 
just asked my sponsor Sven Hoexter to review the package.

> The user-readable text output changed to use correct units, but the
> structured output formats intended for automated parsing did not change.

Hmm, interesting.

Thanks,
Martin



  reply	other threads:[~2017-10-26  8:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28  9:06 fio: uses the opposite symbol for kibibytes/kilobytes (Kb/KiB) than ISO 80000-1 Martin Steigerwald
2017-10-24  8:06 ` Martin Steigerwald
2017-10-24 16:23   ` Elliott, Robert (Persistent Memory)
2017-10-26  8:42     ` Martin Steigerwald [this message]
2017-10-24  8:13 ` Martin Steigerwald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3016894.pBtxSRvArJ@merkaba \
    --to=martin.steigerwald@proact.de \
    --cc=axboe@kernel.dk \
    --cc=elliott@hpe.com \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox