Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Martin Dev <mrturtledev@gmail.com>, fio@vger.kernel.org
Subject: Re: Unlink after each loop in job
Date: Wed, 3 Aug 2016 08:38:48 -0700	[thread overview]
Message-ID: <48aea5d8-12a5-58ca-9008-913e13bc7a8d@kernel.dk> (raw)
In-Reply-To: <CAG6KGPRQf7Mii35T1drhL=u0mZB8PQEeOMnmuBFWSNgBy4E31A@mail.gmail.com>

On 08/02/2016 11:21 PM, Martin Dev wrote:
> I'm after the following data pattern from a job, which is 1 out of 4
> jobs run at the same time:
>
> Targeted at the filesystem level
> Write Xgb of verifiable data to file
> Verify file
> Delete file
> Loop
>
> The idea is we want to test trim at the file system level, whilst also
> having 3 other jobs that perform different workloads.
>
> Unlink=1 will only trigger after all loops of a job are complete
> exec_post_run will only trigger after all loops of a job are complete

Correct.

> I have implemented the functionality I'm after, by adding a
> unlink_each_loop paremeter to options.c, and in backend.c under the
> while(keep_running) I've added an unlink() to both the if block
> checking verify is false (before the loop continue) and after the
> verification, if the flag is set.
>
> The problem is, I'm not a C programmer (in the slightest), and I don't
> know FIO at all well. My code probably does not live up to the
> standard, or understand the internals of FIO well enough to handle
> errors in the correct way etc.

Don't worry about that! You've already done way more than most people
that would like changes to be made, or features to be added. Send out
what you have, and we can help you drive it to completion.

> So I guess I have 2 questions,
>
> 1) Have I missed something which already does what I need (delete file
> on each loop of a write job)

I don't think we currently have it.

> 2) How can I get someone who actually knows what they're doing to
> implement this feature :)

See above :-)

-- 
Jens Axboe



  reply	other threads:[~2016-08-03 15:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-03  6:21 Unlink after each loop in job Martin Dev
2016-08-03 15:38 ` Jens Axboe [this message]
     [not found]   ` <CAG6KGPSthqs28GTQYSnFGcs_XzQWdALQ8knUS7ook2-_wurcmw@mail.gmail.com>
     [not found]     ` <4ac1a598-480e-bfa6-3704-929c909be5da@kernel.dk>
     [not found]       ` <b67f4217-97f3-f9f9-46a1-92c9b43ba9b9@kernel.dk>
2016-08-05  7:31         ` Martin Dev
2016-08-05 13:50           ` Jens Axboe
2016-08-08  7:19             ` Erwan Velu
2016-08-08 13:50               ` Jens Axboe
2016-08-08 14:14                 ` Erwan Velu
2016-08-08 14:18                   ` Jens Axboe
2016-08-08 15:33                     ` Jens Axboe
2016-08-08 15:47                       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48aea5d8-12a5-58ca-9008-913e13bc7a8d@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=mrturtledev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox