Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Jeff Furlong <jeff.furlong@wdc.com>, Sitsofe Wheeler <sitsofe@gmail.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: fio serialize across jobs
Date: Thu, 12 Jul 2018 11:13:01 -0600	[thread overview]
Message-ID: <48d5448e-de1b-09cd-1abf-6549e65fd097@kernel.dk> (raw)
In-Reply-To: <MWHPR04MB0320201F570BDAC2EB3A46DD8F440@MWHPR04MB0320.namprd04.prod.outlook.com>

General comments on this... Fio does have a notion of having multiple
workers per state, most notably for the offload IO model (io_submit_mode).
That would make ethe most sense to utilize for something like this,
rather than having independent jobs that need to share basically everything.
You end up with a rather large rework, only to arrive at what the offload
IO model can already do.


On 7/9/18 11:58 AM, Jeff Furlong wrote:
> What if we limited the jobs to 2 and limited the second job's QD to 1?  Might that limit the locking overhead?
> 
> Regards,
> Jeff
> 
> -----Original Message-----
> From: Sitsofe Wheeler [mailto:sitsofe@gmail.com] 
> Sent: Friday, July 6, 2018 9:23 PM
> To: Jeff Furlong <jeff.furlong@wdc.com>
> Cc: fio@vger.kernel.org
> Subject: Re: fio serialize across jobs
> 
> Hi,
> 
> On 6 July 2018 at 23:14, Jeff Furlong <jeff.furlong@wdc.com> wrote:
>> Hi All,
>> Back in commit 997b5680d139ce82c2034ba3a0d602cfd778b89b "fio: add serialize_overlap option" the feature was added to prevent write/trim race conditions within the queue.  Can this feature be applied to multiple jobs?  Consider:
>>
>> fio --ioengine=libaio --direct=1  --filename=/dev/nvme0n1 --time_based 
>> --name=test1 --rw=randwrite --runtime=5s --name=test2 --rw=randwrite 
>> --runtime=5s --serialize_overlap=1
>>
>> Would we have to call in_flight_overlap() in a loop with all thread data pointers?
> 
> It would be a be more work (the original serialize_overlap was fiddly to make correct but was easy to get going) but I can see why you might want what you describe. The big problem is that I can't see how you can do it without introducing a large amount of locking into the fio's I/O path. I think this would also border on a feature that diskspd has where multiple threads can do I/O to a single file but they all share a randommap...
> 
> --
> Sitsofe | http://sucs.org/~sits/
> N�����r��y���b�X��ǧv�^�)޺{.n�+�������\x17��ܨ}���Ơz�&j:+v���\a����zZ+��+zf���h���~����i���z�\x1e�w���?����&�)ߢ^[fl===
> 


-- 
Jens Axboe



  reply	other threads:[~2018-07-12 17:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 22:14 fio serialize across jobs Jeff Furlong
2018-07-07  4:23 ` Sitsofe Wheeler
2018-07-09 17:58   ` Jeff Furlong
2018-07-12 17:13     ` Jens Axboe [this message]
2018-08-15  0:04       ` Jeff Furlong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48d5448e-de1b-09cd-1abf-6549e65fd097@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=jeff.furlong@wdc.com \
    --cc=sitsofe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox