From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:32832 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755236Ab0FKMzO (ORCPT ); Fri, 11 Jun 2010 08:55:14 -0400 Message-ID: <4C123231.2090505@fusionio.com> Date: Fri, 11 Jun 2010 14:55:13 +0200 From: Jens Axboe MIME-Version: 1.0 Subject: Re: weird error check for aio_cancel References: <20100611043346.3B7A771AC5@kuma.localdomain> <4C11E372.6070401@fusionio.com> In-Reply-To: <4C11E372.6070401@fusionio.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: fio-owner@vger.kernel.org List-Id: fio@vger.kernel.org To: YAMAMOTO Takashi Cc: fio@vger.kernel.org On 2010-06-11 09:19, Jens Axboe wrote: > On 2010-06-11 06:33, YAMAMOTO Takashi wrote: >> hi, >> >> please look at the following patch. >> >> YAMAMOTO Takashi >> >> Signed-off-by: YAMAMOTO Takashi >> >> commit e7aa7a65700932fe68d96015c06e6e1b1ecea0da >> Author: YAMAMOTO Takashi >> Date: Fri Jun 11 12:32:42 2010 +0900 >> >> fix a weird check of the return value of aio_cancel. >> >> i don't know what this 1 means in the first place but at least >> it isn't portable. instead, check if the i/o has already >> completed. (AIO_ALLDONE) > > You are right, that looks like a genuine bug. The last case of > AIO_NOTCANCELLED should be ok, the caller should use normal completions > to reap the remainders. > > I'll apply this. BTW, since you are on NetBSD, have you noticed any problems with the performance of aio with posixaio there? I have a report that it doesn't work particularly fast on FreeBSD, at least it isn't able to saturate a fast device like a small test app using posixaio would. That sounds like a bug and I'm going to look into it, just wondering if you have seen anything to that extent in your testing. -- Jens Axboe