From: Jens Axboe <jaxboe@fusionio.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: fio@vger.kernel.org
Subject: Re: Have we changed number of fields in fio --minimal output
Date: Wed, 30 Jun 2010 09:34:26 +0200 [thread overview]
Message-ID: <4C2AF382.7000708@fusionio.com> (raw)
In-Reply-To: <4C2AF2EC.1090806@fusionio.com>
On 2010-06-30 09:31, Jens Axboe wrote:
> On 2010-06-29 21:32, Vivek Goyal wrote:
>> Hi,
>>
>> I was running latest fio and noticed that number of fields in fio
>> --minimal output have gone up from 69 to 77. A increase of 8 fields. Don't
>> see any update in --minimal documentation. Is it regarding total latency
>> thing?
>
> Woops yes, there's a total latency in there as well now. Should just be
> 4 extra fields, though. It gets logged after completion latency, but
> before bandwidth stats. I'll update the documentation.
>
> Should we perhaps put a versioning field in there? Now would seem to be
> a good time, since the output has changed anyway. I'm open to
> suggestions from you or other terse output users.
How about redesigning it a bit to make it more bullet proof... We
could prefix series of fields with the value they are logging.
So for instance, the 4 completion latency fields would include
a clat prefix first:
clat[%lu;%lu;%f;%f],foo[%lu;%lu],etc
Would that not be more resilient to future changes? New fields
would not bother you, and reordering should also be fine.
Any other ideas?
--
Jens Axboe
next prev parent reply other threads:[~2010-06-30 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 19:32 Have we changed number of fields in fio --minimal output Vivek Goyal
2010-06-30 7:31 ` Jens Axboe
2010-06-30 7:34 ` Jens Axboe [this message]
2010-06-30 7:44 ` Jens Axboe
2010-06-30 12:59 ` Vivek Goyal
2010-06-30 13:16 ` Jens Axboe
2010-06-30 13:23 ` Jens Axboe
2010-06-30 13:37 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2AF382.7000708@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=fio@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox