From: Jens Axboe <jaxboe@fusionio.com>
To: Radha Ramachandran <radha@google.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: Patch to re-use already filled up pattern in io buffers
Date: Wed, 14 Jul 2010 16:08:14 -0600 [thread overview]
Message-ID: <4C3E354E.3040600@fusionio.com> (raw)
In-Reply-To: <AANLkTilg01hs2RgmLRSSbKcAlJPcr6YL2kyG-AQU8rqk@mail.gmail.com>
On 07/14/2010 12:10 PM, Radha Ramachandran wrote:
> Hi Jens,
> As I was verifying the latest code from head, I realized that we
> actually did not need the IO_U_F_FILLED flag, we can just
> use(overload) the buf_filled_len to check if the buffer is actually
> filled (as this is reset to 0 on a read). This also gave me slight
> performance bump. Attached is the patch for it.
Good point, there's no need for that flag/field at all. Will
apply your patch, thanks.
--
Jens Axboe
prev parent reply other threads:[~2010-07-14 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 0:13 Patch to re-use already filled up pattern in io buffers Radha Ramachandran
2010-07-14 6:33 ` Jens Axboe
2010-07-14 6:44 ` Jens Axboe
2010-07-14 18:10 ` Radha Ramachandran
2010-07-14 22:08 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3E354E.3040600@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=fio@vger.kernel.org \
--cc=radha@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox