From: Jens Axboe <jaxboe@fusionio.com>
To: Steven Pratt <steve@dangyankee.net>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: resend [PATCH] fix ramp_in
Date: Tue, 14 Dec 2010 08:33:07 +0100 [thread overview]
Message-ID: <4D071DB3.9060207@fusionio.com> (raw)
In-Reply-To: <4D068908.8030205@dangyankee.net>
On 2010-12-13 21:58, Steven Pratt wrote:
> Let's try this again without the mangling.
Actually this one is also badly mangled :-)
> There are a couple of problems with the relatively new ramp_in feature
> of fio. First, the estimated time
> to completion did not correctly take it into account and bounces around.
> Second and more importantly,
> the runtime was including ramp in time in throughput calculations even
> though the IO done during that
> time was ignored, thus making throughput metrics incorrect. This patch
> fixes both.
Thanks, I hand applied it. You could also remove runtime[] in
fio.c:thread_main() since it's now unused, I did that.
--
Jens Axboe
prev parent reply other threads:[~2010-12-14 7:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 20:58 resend [PATCH] fix ramp_in Steven Pratt
2010-12-14 7:33 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D071DB3.9060207@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=fio@vger.kernel.org \
--cc=steve@dangyankee.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox