From: Jens Axboe <jaxboe@fusionio.com>
To: Bruce Cran <bruce@cran.org.uk>
Cc: fio@vger.kernel.org
Subject: Re: [patch] Use C99 standard integer types
Date: Wed, 15 Dec 2010 16:29:23 +0100 [thread overview]
Message-ID: <4D08DED3.6000202@fusionio.com> (raw)
In-Reply-To: <20101215150924.00003add@unknown>
On 2010-12-15 16:09, Bruce Cran wrote:
> Since most compilers now have a copy of the C99 inttypes.h header
> available, [u]intX_t types should be preferred over compiler-specific
> types such as __u32 etc. Using the standard types allows clang to build
> fio.
>
> I've attached a patch which updates blktrace_api.h, blktrace.c and
> os/binject.h .
Really blktrace_api.h should just go away, since it's an OS interface
and should be exposed as such. We've traditionally always used __uxx
types in those interfaces. You should not be picking that up on FreeBSD
:-)
> The patch also updates Makefile.FreeBSD to use the -pthread flag
> since it's preferred over -lpthread .
Thanks, I can make that change. In the future, it would be nice if you
would separate different changes into different patches. Any time you
need to write 'the patch also...' it's a hint that it should be split!
--
Jens Axboe
next prev parent reply other threads:[~2010-12-15 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 15:09 [patch] Use C99 standard integer types Bruce Cran
2010-12-15 15:29 ` Jens Axboe [this message]
2010-12-15 16:37 ` Bruce Cran
2010-12-15 18:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D08DED3.6000202@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=bruce@cran.org.uk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox