From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pz0-f42.google.com ([209.85.210.42]:38992 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753265Ab1GWSyA (ORCPT ); Sat, 23 Jul 2011 14:54:00 -0400 Received: by pzk37 with SMTP id 37so5586092pzk.1 for ; Sat, 23 Jul 2011 11:54:00 -0700 (PDT) Message-ID: <4E2B18C5.3090602@evernote.com> Date: Sat, 23 Jul 2011 11:53:57 -0700 From: Dave Engberg MIME-Version: 1.0 Subject: bsrange doesn't accept separate read,write values Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: fio-owner@vger.kernel.org List-Id: fio@vger.kernel.org To: fio@vger.kernel.org The 'bs' and 'bssplit' configuration variables accept separate numbers for read and write operations if you separate them with a comma. For example: bssplit=1k/39:8k/50:64k/11,1k/29:8k/50:64k/21 The documentation for 'bsrange' says it works the same way, but if I try to specify two ranges with a comma, I get an error when I run the app. E.g. if I put this line in the configuration file: bsrange=1k-16k,2k-32k I get this error output: fio: pid=26861, err=22/file:engines/sync.c:62, func=xfer, error=Invalid argument Here's my attempt at a patch for this: *** fio-1.57-orig/parse.c 2011-07-14 11:20:25.000000000 -0700 --- fio-1.57/parse.c 2011-07-23 11:38:12.000000000 -0700 *************** *** 453,458 **** --- 453,464 ---- strncpy(tmp, ptr, sizeof(tmp) - 1); + // Handle bsrange with separate read,write values: + p1 = strchr(tmp, ','); + if (p1) { + *p1 = '\0'; + } + p1 = strchr(tmp, '-'); if (!p1) { p1 = strchr(tmp, ':');