From: Jens Axboe <axboe@kernel.dk>
To: Steven Lang <tirea@google.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: [PATCH] Add code for verify_dump option
Date: Tue, 25 Oct 2011 22:39:17 +0200 [thread overview]
Message-ID: <4EA71E75.40108@kernel.dk> (raw)
In-Reply-To: <CAAUT-yPmmiUVeKDXLCKzUxL8uyYHgAT_8buF3Oor_rpy7QqBaw@mail.gmail.com>
On 2011-10-25 22:33, Steven Lang wrote:
> The verify_dump option is defined and documented, but does nothing.
> This one-liner enables the option.
>
> One thing I wanted to open a small discussion on is the default
> behavior. When the verify dump behavior was added, it was something
> new, so it seems more sensible to disable it by default to keep the
> old behavior; and had it been in for less time I might have been
> tempted to include that in the patch. However, even ignoring the
> change in behavior, it seems odd and possibly surprising/unexpected to
> someone who does not have experience with fio to have it suddenly spit
> out extra files; all the other options to write files
> (write_iolog/write_bw_log/write_lat_log) only write anything if
> requested. Is there a good argument to why this option would be
> enabled by default?
Thanks, applied. You are right, it probably should have been off by
default, and in fact probably should be even now.
--
Jens Axboe
prev parent reply other threads:[~2011-10-25 20:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 20:33 [PATCH] Add code for verify_dump option Steven Lang
2011-10-25 20:39 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA71E75.40108@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=tirea@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox