From: Jens Axboe <axboe@kernel.dk>
To: Josh Carter <public@joshcarter.com>
Cc: fio@vger.kernel.org
Subject: Re: [PATCH] Fix initialization of lastrate when using ratemin
Date: Tue, 22 Nov 2011 09:36:02 +0100 [thread overview]
Message-ID: <4ECB5EF2.3070804@kernel.dk> (raw)
In-Reply-To: <36E51B62-69B0-4FCB-8D86-1603D3C21CF9@joshcarter.com>
On 2011-11-18 22:37, Josh Carter wrote:
> fio was copying td->bw_sample_time (single timeval) into td->lastrate
> (array of two timevals) using the latter's size. Thus is would get one
> timeval worth of good data plus who-knows-what for the second timeval.
> I'm pretty sure the intent of this code was to copy bw_sample_time
> into both members of lastrate.
Thanks, applied!
--
Jens Axboe
prev parent reply other threads:[~2011-11-22 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 21:37 [PATCH] Fix initialization of lastrate when using ratemin Josh Carter
2011-11-22 8:36 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECB5EF2.3070804@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=public@joshcarter.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox