From: Vincent Fu <vincentfu@gmail.com>
To: Rebecca Cran <rebecca@bsdio.com>,
fio@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: configure on FreeBSD reports "grep: The -P option is not supported"
Date: Mon, 19 Sep 2022 10:24:02 -0400 [thread overview]
Message-ID: <4f2ca76e-30a3-e58d-4b13-6c1a43a6fddc@gmail.com> (raw)
In-Reply-To: <26076f36-54d5-ca6e-0b96-a7371b1c5e49@bsdio.com>
On 9/19/22 09:15, Rebecca Cran wrote:
> On 9/19/22 07:12, Vincent Fu wrote:
>> On 9/18/22 23:33, Rebecca Cran wrote:
>>> It looks like commit 7ff204c83595cd7d6b7b6a813d9fda97afd25198
>>> introduced an error on some systems such as FreeBSD, whose grep
>>> doesn't support -P.
>>>
>>> num() {
>>> echo "$1" | grep -P -q "^[0-9]+$"
>>> }
>>>
>>> ./configure now reports:
>>>
>>> grep: The -P option is not supported
>>> seed_buckets 4
>>>
>>> Is -P required?
>>>
>>
>> Hello Bex,
>>
>> Does it work for you to replace -P with -E?
>>
>> Alternatively, what if we replaced grep with
>>
>> test "$1" -eq "$1" 2>/dev/null
>
>
> Replacing it with -E works.
>
>
Bex, change committed here:
https://github.com/axboe/fio/commit/d14687025c0c61d047e4252036d1b024d62cb0a6
Thanks.
Vincent
prev parent reply other threads:[~2022-09-19 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 3:33 configure on FreeBSD reports "grep: The -P option is not supported" Rebecca Cran
2022-09-19 13:12 ` Vincent Fu
2022-09-19 13:15 ` Rebecca Cran
2022-09-19 14:24 ` Vincent Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f2ca76e-30a3-e58d-4b13-6c1a43a6fddc@gmail.com \
--to=vincentfu@gmail.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=rebecca@bsdio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox