Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Mike Ryan <mike.ryan@inktank.com>
Cc: fio@vger.kernel.org
Subject: Re: generating latency logs
Date: Tue, 07 Aug 2012 15:43:06 +0200	[thread overview]
Message-ID: <50211B6A.2070505@kernel.dk> (raw)
In-Reply-To: <20120807010300.GD12248@splice>

On 08/07/2012 03:03 AM, Mike Ryan wrote:
> I'm trying to generate a latency log, but no log file is ever created.
> I'm using the version tagged as fio-2.0.8 in git. This is how I'm
> invoking fio:
> 
>   fio --latency-log=/tmp/log --output=/tmp/log random_write.fio

The latency/bw logs are named from the job name, so you can't actually
give it a specific name with the (global) command line option. You'd
need to use the job option to do that.

That said, it does look broken in that we don't inherit the global
setting. Does the below make it work?

diff --git a/init.c b/init.c
index 3865d09..6aad492 100644
--- a/init.c
+++ b/init.c
@@ -1169,6 +1169,8 @@ static int fill_def_thread(void)
 
 	fio_getaffinity(getpid(), &def_thread.o.cpumask);
 	def_thread.o.timeout = def_timeout;
+	def_thread.o.write_lat_log = write_lat_log;
+	def_thread.o.write_bw_log = write_bw_log;
 
 	/*
 	 * fill default options

-- 
Jens Axboe


  reply	other threads:[~2012-08-07 13:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07  1:03 generating latency logs Mike Ryan
2012-08-07 13:43 ` Jens Axboe [this message]
2012-08-07 14:47   ` Mike Ryan
2012-08-08  5:23     ` Kyle Hailey
2012-08-08  5:26     ` Kyle Hailey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50211B6A.2070505@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=mike.ryan@inktank.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox