From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fio-owner@vger.kernel.org>
Received: from mx1.fusionio.com ([66.114.96.30]:42417 "EHLO mx1.fusionio.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753980Ab2HaPLN (ORCPT <rfc822;fio@vger.kernel.org>);
	Fri, 31 Aug 2012 11:11:13 -0400
Message-ID: <5040D40E.10601@fusionio.com>
Date: Fri, 31 Aug 2012 08:11:10 -0700
From: Jens Axboe <jaxboe@fusionio.com>
MIME-Version: 1.0
Subject: Re: [PATCH] fio: fix a doc bug(change timeout to runtime)
References: <CADu=CFo_okoQP7MDK01VgLXDKR1wDodSm39UCTLw_x+OXbj96A@mail.gmail.com>
In-Reply-To: <CADu=CFo_okoQP7MDK01VgLXDKR1wDodSm39UCTLw_x+OXbj96A@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Sender: fio-owner@vger.kernel.org
List-Id: fio@vger.kernel.org
To: liang xie <xieliang007@gmail.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>

On 2012-08-31 02:35, liang xie wrote:
> From 686c70cc5aacdc5623e4d71e566bbfef7a6abacd Mon Sep 17 00:00:00 2001
> From: xieliang <xieliang@xiaomi.com>
> Date: Fri, 31 Aug 2012 17:19:57 +0800
> Subject: [PATCH 1/1] fio:fix a doc bug(change timeout to runtime)

Your patch lacks an explanatory changelog message.

> diff --git a/README b/README
> index 8bce835..d19af4b 100644
> --- a/README
> +++ b/README
> @@ -121,7 +121,7 @@ Command line
>  $ fio
>  	--debug			Enable some debugging options (see below)
>  	--output		Write output to file
> -	--timeout		Runtime in seconds
> +	--runtime		Runtime in seconds

They are functionally equivelant.

> @@ -138,8 +138,8 @@ $ fio
>  				May be "always", "never" or "auto"
>  	--section=name		Only run specified section in job file.
>  				Multiple sections can be specified.
> -	--alloc-size=kb	Set smalloc pool to this size in kb (def 1024)
> -	--warnings-fatal Fio parser warnings are fatal
> +	--alloc-size=kb		Set smalloc pool to this size in kb (def 1024)
> +	--warnings-fatal 	Fio parser warnings are fatal
>  	--max-jobs		Maximum number of threads/processes to support
>  	--server=args		Start backend server. See Client/Server section.
>  	--client=host		Connect to specified backend.
> @@ -161,11 +161,11 @@ options in fio. Currently the options are:
> 
>  	process		Dump info related to processes
>  	file		Dump info related to file actions
> -	io			Dump info related to IO queuing
> -	mem			Dump info related to memory allocations
> +	io		Dump info related to IO queuing
> +	mem		Dump info related to memory allocations
>  	blktrace	Dump info related to blktrace setup
>  	verify		Dump info related to IO verification
> -	all			Enable all debug options
> +	all		Enable all debug options
>  	random		Dump info related to random offset generation
>  	parse		Dump info related to option matching and parsing
>  	diskutil	Dump info related to disk utilization updates

Applied these.

> diff --git a/fio.1 b/fio.1
> index 5b61e43..086cf9d 100644
> --- a/fio.1
> +++ b/fio.1
> @@ -20,8 +20,8 @@ list all available tracing options.
>  .BI \-\-output \fR=\fPfilename
>  Write output to \fIfilename\fR.
>  .TP
> -.BI \-\-timeout \fR=\fPtimeout
> -Limit run time to \fItimeout\fR seconds.
> +.BI \-\-runtime \fR=\fPruntime
> +Limit run time to \fIruntime\fR seconds.
>  .TP
>  .B \-\-latency\-log
>  Generate per-job latency logs.

Also equivalant. But it would not hurt to mention both.

-- 
Jens Axboe